Allow CheckCertificateRevocation to be set on connection string #1591
Conversation
mgravell
left a comment
mgravell
left a comment
There was a problem hiding this comment.
Missing inclusion when generating a string - see public string ToString(bool includePassword) - and should probably be a test for that (perhaps just test the output of options.ToString() in ConfigurationOption_CheckCertificateRevocation?) - but otherwise: looks great, thanks!
|
ToString functionality added and unit-tested |
|
Looks fine, thanks. I'll pull it locally before merging, but: 👍 |
|
Merging main in here to get build checks decent |
|
Hi @mgravell , @NickCraver , Any news on this? I don't know why the build fails, as my changes are not related to the errors there (I think 8-D), and I created my Fork from master... Please, let me know if I can help here somehow... |
|
@lwlwalker I'm not concerned about the unrelated build failures - I just haven't had time to revisit for a build/merge session |
|
merged with thanks |
3 participants
This configuration setting can't be set right now using connection string.
Usage example:
"redishost:6380,ssl=True,checkCertificateRevocation=false"