Do not invert the range if the max value is default(RedisValue)
#1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially we need to ensure that if `Order` is set to "Ascending" and the `max` value is `default(RedisValue)` that the range command is issued correctly.
Contributor
Author
|
It looks like the tests that are failing are all related to NRediSearch: |
mgravell
approved these changes
Oct 21, 2020
Collaborator
|
merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
stopvalue isdefault(RedisValue)and is compared against astartvalue that isn't the result fromstart.CompareTo(stop)is1, which would reverse the range, which would cause the library to emit an incorrect query to Redis.I figured this change would have far fewer impacts than changing how
RedisValue.CompareToworks.This should close issue #992