ForceReplication during failovers to reduce errors in clustered scenarios #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCraver
reviewed
Sep 1, 2020
aravindyeduvaka
force-pushed
the
master
branch
from
711ae7b to
d28a43a
Compare
Contributor
Author
|
@NickCraver, @mgravell ping! |
NickCraver
approved these changes
Oct 24, 2020
Collaborator
NickCraver
left a comment
NickCraver
left a comment
There was a problem hiding this comment.
Looking good, thanks for the tweaks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple people had previously complained that whenever there is a cluster failover, they experience Connection Exceptions for at least close to a minute.
During investigation, @joroda found that this is due to the fact that config check is done roughly every 60 seconds by default and during failover it has to be done almost immediately to eliminate the errors.
This fix shows significant improvement from the tests we did. it reduces errors to around 2 seconds for the 90th percentile case compared to around 56 seconds of errors for 90th percentile right now.