Tests: cleanup & perf pass #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yet another attempt to stabilize testing on CI. Overall: - Code cleanup (thanks Rider) - Reduces some load of the more busy tests. - HackyGetPerf() in Scripting.cs for 100,000 iterations in existing - Overal AsyncOpsQty/SyncOpsQty 10,000 -> 2,000 - Uniques some keys that weren't yet, causing simultaneous framework runs to collide
Collaborator
Author
|
@mgravell I think HackyGetPerf() is a major find - this was clogging the primary even locally barely passing timeouts - I bet this explains a non-trivial number of our CI timeouts. |
mgravell
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another attempt to stabilize testing on CI.
Overall: