Port relocations off defaults for testing #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 22, 2020 10:05
We're getting conflicts with other use cases locally and want to move off the default ports for test instances. This (hopefully) does that correctly. Note, docker bits need to be re-initialized locally to clear state: ``` cd /tests/RedisConfigs docker-compose down docker-compose up --build --force-recreate --no-deps redis ```
Collaborator
Author
|
I'll re-build one for saner testing after #1558 which improves testing stability. |
mgravell
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting conflicts with other use cases locally and want to move off the default ports for test instances. This (hopefully) does that correctly.
Note, docker bits need to be re-initialized locally to clear state: