Skip to content

Conversation

@mgravell
Copy link
Collaborator

  • impacts DBSIZE, FLUSHDB, KEYS, SCAN
  • changes default parameter value from 0 to -1 (needs rebuild of caller to recognize, this is fine)
  • adds a helper method to standardize the behavior between call-sites

…, KEYS, SCAN; this normalizes it with IDatabase[Async]
Copy link
Collaborator

@NickCraver NickCraver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I’d suggest adding what the negative passed value was (for easier debugging - since it’s almost always logs) in the argument exception is all :)

@mgravell mgravell merged commit 572b918 into master May 29, 2020
@NickCraver NickCraver deleted the server-default-db branch July 31, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants