Remove Unspecified/ from errors and test tweaks #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2020 10:21
I've seen this confusing people in issues when it's just not relevant at all. If there is an address familiy specified, we'll see it. If there's not, there's no point in "Unspecified/" being prepended. This is something .NET Does from DNSEndPoint, not us. Also adds a test for ExceptionFactory.Timeout to make sure our format is good.
I WSL 2 it appears there's a bit of clock jitter - handle it in the tests without being too permissive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In going through issues I see many users confused by
Unspecified/and it really served no purpose. Let's get a quick win (and add a test for it).Also, WSL2 it appears has clock jitter - we can accommodate that while having a valid test, fixing that local case.