Add Condition.SortedSetLengthEqual with min and max score #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luaneko
changed the title
Collaborator
|
Perfectly fine with the concept - looks fine. Code looks OK at first
eyeball. Will need to check it in more detail, but: passes the sniff test.
Thanks, good job.
Can I confirm that you're able and willing (and thus doing so) to freely
contribute this code in line with the projects licence, assigning any and
all IP/copyright in the code here to the project?
(Note to self: we need to get a CLA-bot!)
…On Thu, 23 Jan 2020, 18:04 Min, ***@***.***> wrote:
Resolves #1331
<#1331>
------------------------------
You can view, comment on, or merge this pull request online at:
#1332
Commit Summary
- Add sorte set length condition with range
- Improve range condition test
File Changes
- *M* src/StackExchange.Redis/Condition.cs
<https://github.com/StackExchange/StackExchange.Redis/pull/1332/files#diff-0>
(97)
- *M* tests/StackExchange.Redis.Tests/Transactions.cs
<https://github.com/StackExchange/StackExchange.Redis/pull/1332/files#diff-1>
(78)
Patch Links:
- https://github.com/StackExchange/StackExchange.Redis/pull/1332.patch
- https://github.com/StackExchange/StackExchange.Redis/pull/1332.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1332?email_source=notifications&email_token=AAAEHMD22DLRHC7W5GUYEETQ7HLZLA5CNFSM4KK2UIH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIKGPZA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEHMB6AZI4QOPO74EWMJTQ7HLZLANCNFSM4KK2UIHQ>
.
|
Author
Yes. |
Collaborator
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1331