Skip to content

Fix builds for all packages on Linux #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NickCraver merged 15 commits into from
Jan 6, 2020
Merged

Fix builds for all packages on Linux #1316

NickCraver merged 15 commits into from
Jan 6, 2020

Conversation

@NickCraver
Copy link
Collaborator

@NickCraver NickCraver commented Dec 31, 2019 •
edited
Loading

Note that we're only building StackExchange.Redis and NRediSearch in the CI build so this wasn't apparent as an issue, but it's also easily remedied. Cleaning up the xUnit MyGet feed as well since it was an intermittent issue earlier in testing this...and turns out we don't use any betas or need them anymore, so why not simplify anyhow.

Overall, this is a simpler alternative to #1313 and more build simplification/cleanup:

Total changes:

  • Moves to 3.x build SDK (just to update)
    • Moves to Visual Studio 2019 AppVeyor build image, for 3.x support (removes need to install SDK)
    • Rolls forward to latest version
  • Moves to Build.csproj for building
    • Simplifies build.ps1
  • Adds NRediSearch to the test suite (on Linux in CI, since Windows is against 3.x)
    • Adds RedisFeatures.Module (against v 4.0.0) to guard tests against
    • Makes NRediSearch.Tests reference StackExchange.Redis.Tests and support test skipping
  • Makes copyright year range dynamic for the library
  • Moves LangVersion to latest and in one place (root Directory.Build.props)
  • Uses Microsoft.NETFramework.ReferenceAssemblies to build net4x on Linux
  • Uses IsPackable to default to excluded then reverses to true only for the src/ directory
  • Removes xUnit MyGet feed, since we're on stable builds now
  • Adds new files (and corrects old) in .sln
  • Removes LibTargetFrameworks to simplify since it's less complex given the above changes

cc @mgravell for eyes - this should be all set now!

Fix builds for all packages on Linux
8273c11 
Note that we're only building StackExchange.Redis and NRediSearch in the CI build so this wasn't apparent as an issue, but it's also easily remedied.

Cleaning up the xunit MyGet feed as well since it was an intermittent issue earlier in testing this...and turns out we don't use any betas or need them anymore, so why not simplify anyhow.
@NickCraver NickCraver mentioned this pull request Dec 31, 2019
Closed
@gkorland
Copy link
Contributor

gkorland commented Jan 1, 2020

@NickCraver thanks! it seems like it did solve the build issue.
But, now I'm getting this error dotnet test

Testhost process exited with error: It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '2.1.0' was not found.
  - The following frameworks were found:
      3.1.0 at [/snap/dotnet-sdk/57/shared/Microsoft.NETCore.App]
You can resolve the problem by installing the specified framework and/or SDK.
The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=2.1.0&arch=x64&rid=ubuntu.19.10-x64
. Please check the diagnostic logs for more information.

@NickCraver
Copy link
Collaborator Author

NickCraver commented Jan 1, 2020

@gkorland where are you running dotnet test? Regardless of directory, you'll still need to have each of the runtimes installed to test against, e.g. 2.1.x here. While the SDK builds previous versions, it cannot test them. This isn't something we can or should change - to test you'll need to have each test target version installed.

This happens on the CI build agents as well, the versions are just already in the images (since testing against various versions is common).

Nick Craver added 13 commits January 1, 2020 08:12
Simplify build all around
8ee93fe 
This further simplifies the build using traversal SDK and less conditions all around.
Use 3.x SDK
35b5984
xUnit cleanup
34eef72
Order theory test
47239d5
LangVersion centralization
2c210e4
Centralize more bits in Directory.Build.props
f77f61f 
50/50 on if this works for net4x Ubuntu exclusion on tests...
Moar moving cheese
bf88b97 
Also: dynamic years!
Fix misc breaks
ebf5c62
Remove Packing prop and use IsPackable
b95fea4 
Use the new hotness!
Merge remote-tracking branch 'origin/master' into craver/linux-buildable
555d571
Update .sln to include new build shizzle
f557e61
Add RedisFeatures.Module to switch NRediSearch tests on
fe9730b 
This will need more love, but let's see where we stand after this.
NRediSearch: support test skipping!
b79b50f
@NickCraver
Copy link
Collaborator Author

NickCraver commented Jan 1, 2020

@mgravell when you're back in action - this is good for a look.

All changes list above, but the big ones that matter mot:

  • Simplifies the build
  • Builds all projects not just the lib to ensure no breaks for any PR
  • Tests NRediSearch in the build whenever possible

This doesn't fix any of the current test stability, just moving cheese and improving how we build.

@NickCraver NickCraver mentioned this pull request Jan 1, 2020
Merged
Moving to C# 8.0
b426f75 
Talked with Marc, needed for async enumerables soon.
@NickCraver NickCraver merged commit 9976b28 into master Jan 6, 2020
@NickCraver NickCraver deleted the craver/linux-buildable branch January 6, 2020 23:32
@guykorlandredis
Copy link

guykorlandredis commented Jan 9, 2020

@NickCraver after this PR trying to build locally using dotnet build, I started to the get the following error.

Microsoft (R) Build Engine version 16.4.0+e901037fe for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1011: Specify which project or solution file to use because this folder contains more than one project or solution file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgravell mgravell mgravell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NickCraver @gkorland @guykorlandredis @mgravell