add support for netcoreapp3.1 and build on none windows #1313
Conversation
|
A couple of questions:
|
|
I couldn't find another way to make it compile on Ubuntu with netcoreapp3.1. $ dotnet build
...
/snap/dotnet-sdk/57/sdk/3.1.100/Microsoft.Common.CurrentVersion.targets(1175,5): error MSB3644:
The reference assemblies for .NETFramework,Version=v4.7.2 were not found.
To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application.
You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks [/home/guy/dotnetworkspace/StackExchange.Redis/tests/BasicTest/BasicTest.csproj] |
|
Right, that was the context I was missing (on the platform build bit) - it seems obvious in hindsight, but it didn't click at the time - probably would have been worth clarifying in the original description :) So; sounds OK to me, and we probably should indeed make sure we test on the current runtime. @NickCraver - you know a lot more about the CI implications than me - any views here? |
|
Will take a peek at this tonight - it'd be better to use https://www.nuget.org/packages/Microsoft.NETFramework.ReferenceAssemblies/ probably and be buildable on all but only test on the appropriate for the platform. Cleaning up after holidays here, but should be able to poke some afterwards. |
|
Hey all, I threw up a simpler PR on how to achieve this in #1316 :) |
|
I'm going to close this out since #1316 is the correct path there - let's discuss any issues you have building there, but it appears to be missing runtimes (which we require) only after the fixes! |
Note that we're only building `StackExchange.Redis` and `NRediSearch` in the CI build so this wasn't apparent as an issue, but it's also easily remedied. Cleaning up the xUnit MyGet feed as well since it was an intermittent issue earlier in testing this...and turns out we don't use any betas or need them anymore, so why not simplify anyhow. Overall, this is a simpler alternative to #1313 and more build simplification/cleanup: Total changes: - Moves to 3.x build SDK (just to update) - Moves to `Visual Studio 2019` AppVeyor build image, for 3.x support (removes need to install SDK) - Rolls forward to latest version - Moves to `Build.csproj` for building - Simplifies `build.ps1` - Adds `NRediSearch` to the test suite (on Linux in CI, since Windows is against 3.x) - Adds `RedisFeatures.Module` (against v 4.0.0) to guard tests against - Makes `NRediSearch.Tests` reference `StackExchange.Redis.Tests` and support test skipping - Makes copyright year range dynamic for the library - Moves `LangVersion` to latest and in one place (root `Directory.Build.props`) - Uses `Microsoft.NETFramework.ReferenceAssemblies` to build `net4x` on Linux - Uses `IsPackable` to default to excluded then reverses to `true` only for the `src/` directory - Removes `xUnit` MyGet feed, since we're on stable builds now - Adds new files (and corrects old) in `.sln` - Removes `LibTargetFrameworks` to simplify since it's less complex given the above changes cc @mgravell for eyes - this should be all set now!
3 participants
No description provided.