add CheckCertificateRevocation of SslStream.AuthenticateAsClient to Configuration #1234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thenticateAsClient
Collaborator
|
I'm fine with this; makes perfect sense, thanks; merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
in an enterprise infrastructure there is not always the possibility to check certificates for revocation. The target server from a certificate is not always accessible, e.g. AWS Cloud on Premise. I need to be able to disable the certificate revocation check.
I customized the documentation in the configuration and added the CheckCertificateRevocation attribute. The SslStream is now extended by a variation in the AuthenticateAsClient method.
The risk that a defect is caused by this change is low. Also there is no breaking change, because the default: CheckCertificateRevocation=true remains the same.
Please record this changerequest. Thank you.