Updated StreamCreateConsumerGroup methods to use the MKSTREAM option. #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
As with #1154, this needs to be done as an overload |
…umerGroup methods.
Contributor
Author
|
@mgravell, this PR has been updated with an overload as well. Thanks Marc. |
|
Any thing I can do to help here? |
ttingen
force-pushed
the
streams_updates
branch
from
e2bb2b1 to
86fc4b5
Compare
Collaborator
|
merging, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
createStreamparameter to theStreamCreateConsumerGroupmethods, the parameter defaults totrue. Also added appropriate tests for the new parameter and its potential values.