Skip to content

Conversation

@mgravell
Copy link
Collaborator

@mgravell mgravell commented Mar 29, 2019

context: #1103

This necessitated a new sentinel value for handling very large (64-bit) ulong, as we need to encode/decode them differently (obviously, they're not large negative numbers) - but we treat everything up to 63-bit as the previous long, for simplicity.

Adding these operators made some of the other operators ambiguous (from the compiler's perspective), so additional operators were also added to make this work without complaint.

Additionally:

  • some tweaks to remove unnecessary string allocations (by using the Utf8Parser) were exploited
  • all existing direct access to the overloaded field were removed; that was getting dangerous - there are now properties for all of these uses

@mgravell mgravell requested a review from NickCraver March 29, 2019 15:35
@mgravell
Copy link
Collaborator Author

PR appears to impact Streams.StreamPositionValidateBeginning and Streams.StreamPositionDefaultValueIsBeginning - I'll investigate why when I can

@mgravell mgravell merged commit 55a4e09 into master Apr 8, 2019
@NickCraver NickCraver deleted the issue1103 branch July 21, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants