@@ -445,9 +445,10 @@ func (feast *FeastServices) setDeployment(deploy *appsv1.Deployment) error {
445445 }
446446
447447 deploy .Labels = feast .getLabels ()
448+ selectorLabels := feast .getSelectorLabels ()
448449 deploy .Spec = appsv1.DeploymentSpec {
449450 Replicas : replicas ,
450- Selector : metav1 .SetAsLabelSelector (deploy . GetLabels () ),
451+ Selector : metav1 .SetAsLabelSelector (selectorLabels ),
451452 Strategy : feast .getDeploymentStrategy (),
452453 Template : corev1.PodTemplateSpec {
453454 ObjectMeta : metav1.ObjectMeta {
@@ -864,7 +865,7 @@ func (feast *FeastServices) setService(svc *corev1.Service, feastType FeastServi
864865 }
865866
866867 svc .Spec = corev1.ServiceSpec {
867- Selector : feast .getLabels (),
868+ Selector : feast .getSelectorLabels (),
868869 Type : corev1 .ServiceTypeClusterIP ,
869870 Ports : []corev1.ServicePort {
870871 {
@@ -1022,7 +1023,7 @@ func (feast *FeastServices) applyTopologySpread(podSpec *corev1.PodSpec) {
10221023 MaxSkew : 1 ,
10231024 TopologyKey : "topology.kubernetes.io/zone" ,
10241025 WhenUnsatisfiable : corev1 .ScheduleAnyway ,
1025- LabelSelector : metav1 .SetAsLabelSelector (feast .getLabels ()),
1026+ LabelSelector : metav1 .SetAsLabelSelector (feast .getSelectorLabels ()),
10261027 }}
10271028}
10281029
@@ -1045,7 +1046,7 @@ func (feast *FeastServices) applyAffinity(podSpec *corev1.PodSpec) {
10451046 Weight : 100 ,
10461047 PodAffinityTerm : corev1.PodAffinityTerm {
10471048 TopologyKey : "kubernetes.io/hostname" ,
1048- LabelSelector : metav1 .SetAsLabelSelector (feast .getLabels ()),
1049+ LabelSelector : metav1 .SetAsLabelSelector (feast .getSelectorLabels ()),
10491050 },
10501051 }},
10511052 },
@@ -1106,12 +1107,24 @@ func (feast *FeastServices) getFeastTypeLabels(feastType FeastServiceType) map[s
11061107 return labels
11071108}
11081109
1109- func (feast * FeastServices ) getLabels () map [string ]string {
1110+ // getSelectorLabels returns the minimal label set used for immutable selectors
1111+ // (Deployment spec.selector, Service spec.selector, TopologySpreadConstraints, PodAffinity).
1112+ // This must NOT change after initial resource creation.
1113+ func (feast * FeastServices ) getSelectorLabels () map [string ]string {
11101114 return map [string ]string {
11111115 NameLabelKey : feast .Handler .FeatureStore .Name ,
11121116 }
11131117}
11141118
1119+ // getLabels returns the full label set for mutable metadata (ObjectMeta.Labels).
1120+ // Includes the managed-by label used by the informer cache filter.
1121+ func (feast * FeastServices ) getLabels () map [string ]string {
1122+ return map [string ]string {
1123+ NameLabelKey : feast .Handler .FeatureStore .Name ,
1124+ ManagedByLabelKey : ManagedByLabelValue ,
1125+ }
1126+ }
1127+
11151128func (feast * FeastServices ) setServiceHostnames () error {
11161129 feast .Handler .FeatureStore .Status .ServiceHostnames = feastdevv1.ServiceHostnames {}
11171130 domain := svcDomain + ":"
@@ -1489,10 +1502,10 @@ func IsDeploymentAvailable(conditions []appsv1.DeploymentCondition) bool {
14891502// container that is in a failing state. Returns empty string if no failure found.
14901503func (feast * FeastServices ) GetPodContainerFailureMessage (deploy appsv1.Deployment ) string {
14911504 podList := corev1.PodList {}
1492- labels := feast .getLabels ()
1505+ selectorLabels := feast .getSelectorLabels ()
14931506 if err := feast .Handler .Client .List (feast .Handler .Context , & podList ,
14941507 client .InNamespace (deploy .Namespace ),
1495- client .MatchingLabels (labels ),
1508+ client .MatchingLabels (selectorLabels ),
14961509 ); err != nil {
14971510 return ""
14981511 }
0 commit comments