Skip to content

Remove Splat External Dependency #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anaisbetts merged 2 commits into from
May 15, 2020
Merged

Remove Splat External Dependency #1578

anaisbetts merged 2 commits into from
May 15, 2020

Conversation

@nickhodge
Copy link

@nickhodge nickhodge commented Jan 17, 2020

  1. Take the 1.6.2 branch of reactiveui/splat
  2. Take the bare minimum required for Squirrel, change name space
  3. Remove NuGet references to Splat
  4. Correctly name things
  5. Update to VS2019, Update GitVersioning

Tests ran 100% before and after this change.

@nickhodge nickhodge requested a review from anaisbetts January 17, 2020 05:05
@nickhodge
Copy link
Author

nickhodge commented Jan 17, 2020

hmm ... failing because VS2019 vs VS2017?

@anaisbetts
Copy link
Contributor

anaisbetts commented Jan 27, 2020

I'll have a look at this soon

@samirem
Copy link

samirem commented Feb 17, 2020

Waiting eagerly on this one, it would solve #1462 which has been blocking ReactiveUI users

@Hyrius
Copy link

Hyrius commented Apr 7, 2020

Any update about this pull request?

@anaisbetts
Copy link
Contributor

anaisbetts commented Apr 7, 2020

This is Very Much on my list, @nickhodge has done some awesome work here, sorry I'm dragging my feet.

@nickhodge
Copy link
Author

nickhodge commented Apr 7, 2020

I am Helping

@AppFzx
Copy link

AppFzx commented Apr 28, 2020

Any update on status?

@anaisbetts anaisbetts merged commit 2a769f4 into Squirrel:develop May 15, 2020
This was referenced May 15, 2020
Closed
Merged
@guidovanhilst
Copy link

guidovanhilst commented May 31, 2020

Any update about this pull request?

I am having trouble using Squirrel.Windows and ReactiveUI due to error in Splat:

Exception in call to UpdateManager.UpdateApp():
"Method not found: 'Void Splat.IFullLogger.Info(System.String, !!0)'."

I am using the following nuget packages:
Splat 9.4.5.
ReactiveUI 9.19.5
Squirrel 1.9.1

I believe this commit solves the problem?
Is there going to be an update on www.nuget.org/packages/squirrel.windows?

Thanks, Guido

@wsaeed
Copy link

wsaeed commented Jun 5, 2020

@anaisbetts What was the reason to revert back to VS 2017?

@ComtelJeremy
Copy link

ComtelJeremy commented Jun 10, 2020

@anaisbetts Any way this can get pushed to a release? We are unable to release our app's latest version since we now use the latest ReactiveUI... Pretty please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anaisbetts anaisbetts Awaiting requested review from anaisbetts

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nickhodge @anaisbetts @samirem @Hyrius @AppFzx @guidovanhilst @wsaeed @ComtelJeremy