Skip to content

Conversation

@robmen
Copy link
Contributor

@robmen robmen commented May 12, 2019

Plus fixed a few whitespace and warnings

This is one step closer to automated releases.

@robmen robmen requested a review from shiftkey May 12, 2019 20:56
@shiftkey shiftkey self-assigned this May 12, 2019
Copy link
Contributor

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robmen let me know what things I should focus on aside from seeing the build pass

@robmen
Copy link
Contributor Author

robmen commented May 17, 2019

@robmen let me know what things I should focus on aside from seeing the build pass

Yeah, not much here to look at. Everything builds the same differently. Unit tests all pass which is my best gauge of correctness at this time.

@shiftkey shiftkey merged commit 6867fa2 into develop May 24, 2019
@shiftkey shiftkey deleted the rob/modernize-build branch May 24, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants