Skip to content

Commit 6d33b93

Browse files
cliffhallclaude
andcommitted
docs: reduce the PR template to the issues-not-PRs banner
Pull requests are turned off once modelcontextprotocol#4939 lands on main, so the template's only job is the notice that turns outside PRs away. Drop the policy comment, which duplicated the banner, and the maintainers' body skeleton and checklist. The sections and the full checklist move to pr-flow step 6, and AGENTS.md's checklist rule, tree entry and version-PR exception point there instead of at the template. Closes modelcontextprotocol#4960 Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: cliffhall <[email protected]>
1 parent 3758d43 commit 6d33b93

3 files changed

Lines changed: 39 additions & 91 deletions

File tree

‎.claude/skills/pr-flow/SKILL.md‎

Lines changed: 30 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,8 @@ One thing the gate deliberately leaves out:
131131

132132
## 5. Client evidence
133133

134-
A PR shows the change working, as the PR template's **How Has This Been
135-
Tested?** section asks. Here that means evidence from clients, not screenshots.
134+
A PR shows the change working, under the body's **How Has This Been Tested?**
135+
section (step 6). Here that means evidence from clients, not screenshots.
136136

137137
**A change to server behavior** (a tool, resource, prompt, capability,
138138
transport or error it returns) records, for **both** the Inspector V2 and an
@@ -159,6 +159,33 @@ Put the evidence in the PR body under **How Has This Been Tested?**.
159159
Base **`v2/main`** (or the lower branch, when stacked). **Never `main`.** Label
160160
it `v2`. The body's **first line is `Closes #<N>`**.
161161

162+
The body carries these sections, in order. `.github/pull_request_template.md`
163+
is only the "issues, not PRs" banner that turns outside PRs away, so this list
164+
is where the structure lives:
165+
166+
- **Description**: what changed and why.
167+
- **Server Details**: the server (or "none (repository-wide)") and what in it
168+
changed (tools, resources, prompts, docs, …).
169+
- **Motivation and Context**: the problem it solves; usually a pointer to the
170+
issue.
171+
- **How Has This Been Tested?**: the evidence from step 5.
172+
- **Breaking Changes**: whether users must change their client configuration.
173+
- **Types of changes**: tick each that applies: bug fix, new feature, breaking
174+
change, documentation update.
175+
- **Checklist**: tick each that holds, and mark one that does not apply as
176+
"(not applicable: <why>)" rather than leaving it blank:
177+
- [ ] I have read the [MCP Protocol Documentation](https://modelcontextprotocol.io)
178+
- [ ] My changes follow MCP security best practices
179+
- [ ] I have updated the server's README accordingly
180+
- [ ] I have added a changeset (`npm run changeset`) if this changes what a
181+
TypeScript server publishes
182+
- [ ] I have tested this with an LLM client
183+
- [ ] My code follows the repository's style guidelines
184+
- [ ] New and existing tests pass locally
185+
- [ ] I have added appropriate error handling
186+
- [ ] I have documented all environment variables and configuration options
187+
- **Additional context** (optional): implementation notes or design decisions.
188+
162189
Write the body to a file and pass it with `--body-file`. A body passed inline
163190
in double quotes goes through the shell, so every backtick in its Markdown runs
164191
as a command substitution and `$VAR` expands. Keep the file outside the
@@ -169,7 +196,7 @@ BODY=$(mktemp)
169196
cat > "$BODY" <<'EOF'
170197
Closes #<N>
171198
172-
<what changed and why, then the template's sections, with the evidence>
199+
<the sections above, with the evidence>
173200
EOF
174201
gh pr create --repo modelcontextprotocol/servers \
175202
--base v2/main --label v2 --title "<title>" --body-file "$BODY"

‎.github/pull_request_template.md‎

Lines changed: 0 additions & 80 deletions
Original file line numberDiff line numberDiff line change
@@ -1,86 +1,6 @@
1-
<!--
2-
⚠️ Before you open this pull request, please read our contribution policy.
3-
4-
We accept ISSUES, NOT PULL REQUESTS from anyone but the repository
5-
maintainers, organization members with write access included.
6-
7-
Design and implementation are done by the maintainers through a
8-
prompt-driven workflow (see AGENTS.md). Outside pull requests are closed,
9-
not merged: a diff written outside that workflow has to be reverse-engineered
10-
to fit our conventions, tests and gates, so it's faster for us to re-derive
11-
the change from your intent.
12-
13-
If you've found a bug or want a feature:
14-
→ Open an issue instead, using the Bug report or Feature request form.
15-
16-
If you've already built the change locally:
17-
→ Open an issue and share the PROMPT(S) you used to generate it, not a
18-
diff. We'll reproduce it through our own workflow.
19-
20-
If you want to list or add a server:
21-
→ Publish it to the MCP Server Registry instead
22-
(https://github.com/modelcontextprotocol/registry).
23-
24-
Full policy:
25-
https://github.com/modelcontextprotocol/servers/blob/main/CONTRIBUTING.md
26-
27-
Maintainers: delete this comment and the banner below, keep the first line
28-
as `Closes #<ISSUE_NUMBER>`, and fill in the sections.
29-
-->
30-
311
> **Heads up:** this repository accepts **issues, not pull requests**, from
322
> anyone but the repository maintainers. Please read
333
> [`CONTRIBUTING.md`](https://github.com/modelcontextprotocol/servers/blob/main/CONTRIBUTING.md) before continuing. If you're not a
344
> maintainer, open an issue (and share the prompt you used, if you've already
355
> built the change) rather than this PR. To make a server discoverable, publish
366
> it to the [MCP Server Registry](https://github.com/modelcontextprotocol/registry).
37-
38-
Closes #<ISSUE_NUMBER>
39-
40-
## Description
41-
42-
## Server Details
43-
44-
<!-- If modifying an existing server, provide details -->
45-
46-
- Server: <!-- e.g., filesystem, git -->
47-
- Changes to: <!-- e.g., tools, resources, prompts -->
48-
49-
## Motivation and Context
50-
51-
<!-- Why is this change needed? What problem does it solve? -->
52-
53-
## How Has This Been Tested?
54-
55-
<!-- Have you tested this with an LLM client? Which scenarios were tested? -->
56-
57-
## Breaking Changes
58-
59-
<!-- Will users need to update their MCP client configurations? -->
60-
61-
## Types of changes
62-
63-
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
64-
65-
- [ ] Bug fix (non-breaking change which fixes an issue)
66-
- [ ] New feature (non-breaking change which adds functionality)
67-
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
68-
- [ ] Documentation update
69-
70-
## Checklist
71-
72-
<!-- Go over all the following points, and put an `x` in all the boxes that apply. -->
73-
74-
- [ ] I have read the [MCP Protocol Documentation](https://modelcontextprotocol.io)
75-
- [ ] My changes follows MCP security best practices
76-
- [ ] I have updated the server's README accordingly
77-
- [ ] I have added a changeset (`npm run changeset`) if this changes what a TypeScript server publishes
78-
- [ ] I have tested this with an LLM client
79-
- [ ] My code follows the repository's style guidelines
80-
- [ ] New and existing tests pass locally
81-
- [ ] I have added appropriate error handling
82-
- [ ] I have documented all environment variables and configuration options
83-
84-
## Additional context
85-
86-
<!-- Add any other context, implementation notes, or design decisions -->

‎AGENTS.md‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ servers/
6161
│ version-packages.yml (the changesets PR), prepare-python-release.yml (the CalVer PR),
6262
│ claude.yml (@claude mentions)
6363
├── .github/ISSUE_TEMPLATE/ Bug and feature issue forms; config.yml routes security and new servers away
64-
├── .github/pull_request_template.md The "issues, not PRs" banner and the maintainers' PR checklist
64+
├── .github/pull_request_template.md The "issues, not PRs" banner that turns outside PRs away
6565
├── RELEASING.md How packages are versioned and published, and how to recover a failed publish
6666
└── CONTRIBUTING.md The contribution policy: issues, not PRs; what is accepted
6767
```
@@ -278,7 +278,7 @@ holds for a maintainer's own one-line fix as much as for a feature.
278278
is merged with a merge commit, never squashed. The flow is the `release`
279279
skill.
280280
- **Exception: the two version PRs that automation opens.** Each changes
281-
version metadata only, so neither answers the template checklist, and each
281+
version metadata only, so neither answers the PR checklist below, and each
282282
is tied to its milestone's **release issue** rather than to an issue of its
283283
own.
284284
- The **Prepare Python Release** PR follows the rest of the rules: the
@@ -293,12 +293,13 @@ holds for a maintainer's own one-line fix as much as for a feature.
293293

294294
No other PR is exempt.
295295

296-
Every PR answers the checklist in
297-
[`.github/pull_request_template.md`](./.github/pull_request_template.md):
298-
the MCP documentation was read for the feature touched, the change follows MCP
299-
security best practices, the server's README is updated, and a **server-facing
300-
change was tested with an LLM client**, with the scenarios tested named under
301-
the template's "How Has This Been Tested?" heading.
296+
Every PR answers the PR checklist in its body: the MCP documentation was read
297+
for the feature touched, the change follows MCP security best practices, the
298+
server's README is updated, and a **server-facing change was tested with an LLM
299+
client**, with the scenarios tested named under the body's "How Has This Been
300+
Tested?" heading. The body's sections and the full checklist are in the
301+
`pr-flow` skill. [`.github/pull_request_template.md`](./.github/pull_request_template.md)
302+
is only the "issues, not PRs" banner; it does not carry them.
302303

303304
## Maintenance rules
304305

0 commit comments

Comments
 (0)