Add support for Gradle configuration cache#495
Merged
Conversation
This commit replaces calls to gradle.buildFinished with an AutoCloseable BuildService, and marks the versions.properties file as used at configuration time, so configuration is invalidated if its content changes, letting dependency updates be applied if any. However, this commit doesn't make refreshVersions own tasks compatible with Gradle configuration cache, because it's almost impossible to do so. Thankfully, this is not a big deal since that doesn't prevent the tasks from completing, and having configuration cache enabled for the main refreshVersions task wouldn't be helpful anyway since it modifies the versions.properties file, which invalidates the configuration cache anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Description
This PR replaces calls to gradle.buildFinished with an AutoCloseable BuildService,
and marks the versions.properties file as used at configuration time,
so configuration is invalidated if its content changes, letting dependency updates
be applied if any.
However, this PR doesn't make refreshVersions own tasks compatible with
Gradle configuration cache, because it's almost impossible to do so.
Thankfully, this is not a big deal since that doesn't prevent the tasks from
completing, and having configuration cache enabled for the main refreshVersions
task wouldn't be helpful anyway since it modifies the versions.properties file,
which invalidates the configuration cache anyway.
📄 Motivation and Context
Allow host projects to use configuration cache.
Closes #228
🧪 How Has This Been Tested?
Tested extensively in
sample-kotlinandsample-multi-moduleslocally.Also, the
check-buildGitHub Action will now run thechecktask with the--configuration-cacheoption.