Repository navigation
Commit 57bb1d4
authored
Fix a flake in ShellTest.SecondaryVsyncCallbackShouldBeCalledAfterVsyncCallback (flutter#190490)
That test calls the engine's ScheduleSecondaryVsyncCallback and
ScheduleFrame APIs. If a vsync occurs between the two calls, then the
secondary callback will be executed at that vsync, but the frame will be
scheduled at the next vsync. That will cause a false negative in the
test.
This PR changes the test to execute the API calls shortly after a vsync
happens. That should ensure that both calls happen during the same vsync
interval.
This also fixes an issue where VsyncWaiter::FireCallback was not
properly resetting the VsyncWaiter's callback. The failure to reset the
callback meant that a second call to AsyncWaitForVsync with a different
callback would not actually take effect.
Fixes flutter#1904301 parent 67cfcfb commit 57bb1d4
2 files changed
Lines changed: 23 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2296 | 2296 | | |
2297 | 2297 | | |
2298 | 2298 | | |
| 2299 | + | |
| 2300 | + | |
| 2301 | + | |
| 2302 | + | |
| 2303 | + | |
| 2304 | + | |
| 2305 | + | |
| 2306 | + | |
| 2307 | + | |
| 2308 | + | |
| 2309 | + | |
| 2310 | + | |
| 2311 | + | |
| 2312 | + | |
| 2313 | + | |
| 2314 | + | |
| 2315 | + | |
2299 | 2316 | | |
2300 | 2317 | | |
2301 | | - | |
2302 | | - | |
2303 | | - | |
2304 | | - | |
2305 | | - | |
2306 | | - | |
2307 | | - | |
2308 | | - | |
2309 | | - | |
2310 | | - | |
2311 | | - | |
| 2318 | + | |
| 2319 | + | |
| 2320 | + | |
2312 | 2321 | | |
| 2322 | + | |
2313 | 2323 | | |
2314 | 2324 | | |
2315 | 2325 | | |
| 2326 | + | |
2316 | 2327 | | |
2317 | 2328 | | |
2318 | 2329 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
0 commit comments