Skip to content

BED-6876 - add SharpHound and SharpHoundCommon version to log #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mykeelium merged 2 commits into from
Nov 20, 2025
Merged

BED-6876 - add SharpHound and SharpHoundCommon version to log #188

mykeelium merged 2 commits into from
Nov 20, 2025
+3 −0

Conversation

@mykeelium
Copy link
Contributor

@mykeelium mykeelium commented Nov 19, 2025 •
edited by coderabbitai bot
Loading

Description

Include the SharpHound and SharpHoundCommon Version in the Logs

Motivation and Context

BED-6876

How Has This Been Tested?

This was tested by creating a build and running the code and inspecting the logs to ensure the changes were available.

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Summary by CodeRabbit

  • Improvements
    • Startup logging now shows detailed version information for the application and its shared library components, making it easier to verify what’s running and troubleshoot environment/version issues.

✏️ Tip: You can customize this high-level summary in your review settings.

@mykeelium mykeelium self-assigned this Nov 19, 2025
@mykeelium mykeelium added the enhancement New feature or request label Nov 19, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025 •
edited
Loading

Walkthrough

Adds two startup log statements that report the executing SharpHound assembly version and the SharpHound Common library assembly version via reflection; also adds using System.Reflection;. No control-flow or public API changes.

Changes

Cohort / File(s) Summary
Version Logging Addition
src/Sharphound.cs		 Adds using System.Reflection; and two log statements reporting SharpHound (Assembly.GetExecutingAssembly().GetName().Version) and SharpHound Common (Assembly.GetAssembly(typeof(CommonLib)).GetName().Version) assembly versions at startup.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify reflection calls retrieve the intended assemblies and versions.
  • Confirm log placement at startup and formatting.
  • Quick check for any potential null reference when resolving Assembly.GetAssembly(typeof(CommonLib)).

Possibly related PRs

Suggested reviewers

  • ktstrader
  • MikeX777

Poem

🐰 I hop through code with curious eyes,

I read my versions under autumn skies,
A whisper in logs, two numbers align,
SharpHound and Common, stamped in a line,
I twitch my nose and bless this little sign.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding SharpHound and SharpHoundCommon version information to logs, with direct reference to the issue tracker (BED-6876).
Description check ✅ Passed The pull request description follows the template structure and includes all key sections: Description, Motivation and Context, testing details, and completed checklist. The author provided meaningful information in each section.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mcuomo/BED-6876
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 781da1e and 0d1afc1.

📒 Files selected for processing (1)
  • src/Sharphound.cs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/Sharphound.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Nov 19, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 094ead7 and 781da1e.

📒 Files selected for processing (1)
  • src/Sharphound.cs (2 hunks)
🔇 Additional comments (1)
src/Sharphound.cs (1)

19-19: LGTM!

The System.Reflection namespace import is correctly placed and necessary for the version logging functionality added below.

@mykeelium mykeelium merged commit 8a2ffd4 into 2.X Nov 20, 2025
3 checks passed
@mykeelium mykeelium deleted the mcuomo/BED-6876 branch November 20, 2025 18:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@rvazarkar rvazarkar rvazarkar approved these changes

Assignees

@mykeelium mykeelium

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mykeelium @rvazarkar