Skip to content

SHCE version bump to 2.8.0 #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
definitelynotagoblin merged 1 commit into from
Oct 23, 2025
Merged

SHCE version bump to 2.8.0 #183

definitelynotagoblin merged 1 commit into from
Oct 23, 2025

Conversation

@definitelynotagoblin
Copy link
Contributor

@definitelynotagoblin definitelynotagoblin commented Oct 23, 2025 •
edited by coderabbitai bot
Loading

Description

SHCE version bump to v2.8.0

Motivation and Context

https://specterops.atlassian.net/browse/BED-6647

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Summary by CodeRabbit

  • Chores
    • Updated version to 2.8.0.

@definitelynotagoblin definitelynotagoblin self-assigned this Oct 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025 •
edited
Loading

Walkthrough

The pull request bumps the assembly Version and FileVersion in Sharphound.csproj from 2.7.2 to 2.8.0 and adds a trailing newline to the project file.

Changes

Cohort / File(s) Change Summary
Version Bump
Sharphound.csproj		 Updated Version and FileVersion from 2.7.2 to 2.8.0; added trailing newline at end of file

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • ktstrader
  • MikeX777

Poem

🐰 A minor hop to version's heights,
From 2.7.2 to 2.8's light,
A trailing newline, neat and clean,
The tidiest release we've seen!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "SHCE version bump to 2.8.0" directly describes the primary change in the changeset, which is bumping the assembly version from 2.7.2 to 2.8.0 in the Sharphound.csproj file. The title is concise, specific, and clearly communicates the main intent of the pull request. A teammate reviewing the pull request history would immediately understand that this change involves a version bump.
Description Check ✅ Passed The pull request description covers most of the required template sections including a clear description, motivation with a linked Jira issue (BED-6647), appropriate categorization as a chore, and confirmation that existing tests passed. While the "How Has This Been Tested?" section is not explicitly filled out with details, this is acceptable for a chore-level version bump change. The author has indicated that all new and existing tests passed in the checklist, which sufficiently addresses testing for this type of change. The description is largely complete and provides the necessary context for understanding and merging the pull request.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch v-bump-2.8
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e6de84 and 01ed524.

📒 Files selected for processing (1)
  • Sharphound.csproj (2 hunks)
🔇 Additional comments (2)
Sharphound.csproj (2)

9-10: Version bump looks good.

The Version and FileVersion properties are consistently updated to 2.8.0, matching the PR objective.

1-47: No orphaned version references found—update is clean.

Verification confirms:

  • No hardcoded "2.7.2" exists anywhere in the codebase
  • Version 2.8.0 is correctly set in Sharphound.csproj (PropertyGroup tags)
  • No AssemblyInfo.cs file exists that could override versions
  • Dynamic version retrieval in JsonDataWriter.cs will automatically reflect the updated version from the .csproj

The modern SDK-style .csproj format auto-generates assembly version attributes at build time, so no additional synchronization is needed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@definitelynotagoblin definitelynotagoblin merged commit dc420a6 into 2.X Oct 23, 2025
2 checks passed
@definitelynotagoblin definitelynotagoblin deleted the v-bump-2.8 branch October 23, 2025 19:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mykeelium mykeelium mykeelium approved these changes

Assignees

@definitelynotagoblin definitelynotagoblin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@definitelynotagoblin @mykeelium