Skip to content

Conversation

@definitelynotagoblin
Copy link
Contributor

@definitelynotagoblin definitelynotagoblin commented Sep 18, 2025

Description

SHC reference version bump.

Motivation and Context

https://specterops.atlassian.net/browse/BED-6485

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Summary by CodeRabbit

  • Chores
    • Updated underlying libraries to the latest patch versions, improving stability, compatibility, and incorporating upstream fixes.
    • This maintenance upgrade reduces potential edge-case failures and prepares the app for future enhancements.
    • No changes to commands, output, or user workflows; behavior remains the same.
    • Minor performance and reliability improvements may be observed in certain environments.

@definitelynotagoblin definitelynotagoblin self-assigned this Sep 18, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 18, 2025

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between d543995 and e88f5af.

📒 Files selected for processing (1)
  • Sharphound.csproj (1 hunks)
 ___________________________________________
< GPU-powered code review. It's the future. >
 -------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting in your project's settings in CodeRabbit to automatically approve the review once all CodeRabbit's comments are resolved.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch anemeth/shc-bump-v4.3.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@definitelynotagoblin definitelynotagoblin merged commit 0b4b074 into 2.X Sep 18, 2025
1 of 2 checks passed
@definitelynotagoblin definitelynotagoblin deleted the anemeth/shc-bump-v4.3.2 branch September 18, 2025 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d543995 and e88f5af.

📒 Files selected for processing (1)
  • Sharphound.csproj (1 hunks)

Comment on lines +28 to +29
<PackageReference Include="SharpHoundCommon" Version="4.3.2" />
<PackageReference Include="SharpHoundRPC" Version="4.3.2" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

🧩 Analysis chain

LGTM on bump; verify NuGet availability and cross-project version consistency.

Versions for SharpHoundCommon and SharpHoundRPC are aligned at 4.3.2. Please confirm no other projects in the solution still pin 4.3.1 and update any packages.lock.json if present.

Run this to verify NuGet availability and detect any mismatched versions across .csproj files:


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Searching for SharpHound package versions across the repo..."
rg -nP -C1 --glob '*.csproj' '<PackageReference Include="SharpHound(Common|RPC)".*Version="([^"]+)"'

echo
echo "Checking NuGet for version 4.3.2 existence..."
for p in SharpHoundCommon SharpHoundRPC; do
  echo "Package: $p"
  curl -s "https://api.nuget.org/v3/registration5-gz-semver2/${p}/index.json" \
    | jq -r '.items[].items[].catalogEntry.version' \
    | tail -n 10
  curl -s "https://api.nuget.org/v3/registration5-gz-semver2/${p}/index.json" \
    | jq -r '.items[].items[].catalogEntry.version' \
    | grep -Fx "4.3.2" >/dev/null && echo "$p 4.3.2 found" || echo "$p 4.3.2 NOT found"
  echo
done

echo "If packages.lock.json exists, ensure it's updated:"
fd packages.lock.json -u || true

Length of output: 554


🏁 Script executed:

#!/bin/bash
set -u

echo "Searching for SharpHound package references in .csproj files..."
rg -nP --glob '**/*.csproj' '<PackageReference\s+Include="SharpHound(?:Common|RPC)".*Version="([^"]+)"' -C1 || true

echo
echo "Checking nuget.org v3-flatcontainer for versions..."
for p in SharpHoundCommon SharpHoundRPC; do
  echo "Package: $p"
  id=$(echo "$p" | tr '[:upper:]' '[:lower:]')
  url="https://api.nuget.org/v3-flatcontainer/${id}/index.json"
  echo "  GET $url"
  if curl -sS --fail "$url" -o /tmp/${id}_index.json; then
    echo "  fetched index.json, showing up to last 10 versions:"
    jq -r '.versions[]' /tmp/${id}_index.json 2>/dev/null | tail -n 10 | sed 's/^/    /' || true
    if jq -r '.versions[]' /tmp/${id}_index.json 2>/dev/null | grep -Fxq "4.3.2"; then
      echo "$p 4.3.2 found on nuget.org"
    else
      echo "$p 4.3.2 NOT found on nuget.org"
    fi
  else
    echo "  ✗ Could not fetch index.json (404 or network error)"
  fi
  echo
done

echo "Looking for packages.lock.json files..."
find . -type f -iname 'packages.lock.json' -print || echo "  none found"

Length of output: 1037


Action required: SharpHoundCommon/SharpHoundRPC v4.3.2 not available on nuget.org — fix package availability or feed.

  • Sharphound.csproj (lines 28–29) references SharpHoundCommon and SharpHoundRPC @ 4.3.2.
  • NuGet check: SharpHoundCommon on nuget.org lists up to 3.0.8 (4.3.2 missing); SharpHoundRPC lookup returned 404 — 4.3.2 is not on nuget.org.
  • No packages.lock.json found in the repo.
  • Fix options: publish 4.3.2 to the feed this repo uses or update NuGet.config to point to the private feed that hosts 4.3.2; otherwise revert the .csproj to a published version and update references. Also confirm no other projects still pin 4.3.1 (search found only Sharphound.csproj).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants