Skip to content

Conversation

@mykeelium
Copy link
Contributor

@mykeelium mykeelium commented May 29, 2025

Description

Updates to SharpHound to check the installed version of .Net Framework to ensure it meets our target. If the system does not, a log will be created and SharpHound will exit.

Motivation and Context

This PR addresses: BED-5936

This change was recommended because some users are on older versions of Windows which can cause issues while running the application since we target a newer version of .Net Framework.

How Has This Been Tested?

This was tested by running SharpHound on a system with .Net Framework 4.7.2 and trying to run the software on a system with .Net Framework 4.6.2. The software was unable to run on the latter system. This system was then updated by installing .Net Framework 4.7.2, which allowed SharpHound to run.

In both the system that could initially run the updated application and the system that was updated to be able to run SharpHound, a collection was run and the data was successfully ingested in a local BloodHound Enterprise Instance.

Screenshots (optional):

The new error log

image

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • As a note, I could not find any documentation specifying the necessary version of .Net Framework on the system. Should there be place for this?
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@mykeelium mykeelium self-assigned this May 29, 2025
@mykeelium mykeelium added the enhancement New feature or request label May 29, 2025
@github-actions
Copy link

github-actions bot commented May 29, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@mykeelium
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mykeelium
Copy link
Contributor Author

recheck

@mykeelium mykeelium merged commit 553f408 into 2.X Jun 2, 2025
1 check passed
@mykeelium mykeelium deleted the mcuomo/BED-5936 branch June 2, 2025 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants