Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Far Cry 5 (with Proton + DXVK) has alternating swapchain pointers during SK_D3D11_RenderCtx::init, causing init release loop #168

Closed
Kethen opened this issue Apr 22, 2024 · 3 comments

Comments

@Kethen
Copy link

Kethen commented Apr 22, 2024

Continuation of #167

Two alternating swapchain pointers were being fed to SK_D3D11_RenderCtx::init by Far Cry 5 with Proton + DXVK, causing init release loop and causes high pcie bandwidth usage

This issue was initially observed in Far Cry 5 + Proton + DXVK, however while narrowing down the issue, I found that it does not happen in Combat Master + Proton + DXVK

Below attaches log from Far Cry 5 + Proton + DXVK (on SK Kethen@53aa50f)

dxgi.log

Would be interesting to see if this happens on windows as well, and if it does, does it produce as big of a performance hit over there as well

@Kaldaien
Copy link
Member

Jeeze, it seems they're going out of their way to break software compatibility :(

Yeah, this is the same bug that makes SK not perform well on Steam Deck since several releases of Proton agao.

It's another thing I can't fix, but maybe you'll have some luck getting them to fix this, as well as their weird Present -> Present1 code.

@Kethen
Copy link
Author

Kethen commented Apr 23, 2024

Jeeze, it seems they're going out of their way to break software compatibility :(

Yeah, this is the same bug that makes SK not perform well on Steam Deck since several releases of Proton agao.

It's another thing I can't fix, but maybe you'll have some luck getting them to fix this, as well as their weird Present -> Present1 code.

For now, I'll dust off my windows vm to see if this Far Cry 5 thing happens on windows 11 d3d11 as well, since out of two games I've tested with Proton it only happened on one; it might as well be the game creating two swap chains, or the disabled ubisoft overlay thing, then actually frequently send it into Present

As for the Present -> Present1 issue, as mentioned in the closed issue, if nothing breaks on DXVK side and gets doitsujin/dxvk#3966 reverted, it should be fixed on Proton when that lands

Kethen added a commit to Kethen/dxvk that referenced this issue Apr 23, 2024
…dBase

similar to doitsujin#3966, avoid
chaining so that dxgi tools attempting to wrap swapchains don't
end up double wrapping

ref: SpecialKO/SpecialK#168
Kethen added a commit to Kethen/dxvk that referenced this issue Apr 23, 2024
similar to doitsujin#3966, avoid
chaining so that dxgi tools attempting to wrap swapchains don't
end up double wrapping

ref: SpecialKO/SpecialK#168
doitsujin pushed a commit to doitsujin/dxvk that referenced this issue Apr 25, 2024
similar to #3966, avoid
chaining so that dxgi tools attempting to wrap swapchains don't
end up double wrapping

ref: SpecialKO/SpecialK#168
@Kethen
Copy link
Author

Kethen commented Apr 26, 2024

closing for now, should be fixed as of doitsujin/dxvk#3968

@Kethen Kethen closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants