Phase 3 Batch 3: dead-state delete pending_b2_blocks_

SonicField · SonicField · commit b92d85e7512a · 2026-04-23T16:53:25.000-07:00
Delete the pending_b2_blocks_ Class B vector + struct PendingBlock + drain loop in translate(). The W26-era refactor of emitInlineExceptionMatch removed all writers but left the queue declaration + drain plumbing as load-bearing-looking dead state. Independent grep verification (theologian 23:35:58Z + librarian 23:50:24Z + spec §2.1 grep-writers-before-Step-A discipline per pythia python#93): 4 reference sites, ZERO writers. Mutation patterns push_back/emplace_back/insert/operator[]/resize/assign/reserve all NOT FOUND across cpython/. PendingBlock struct unused outside the deleted field. Reframes Phase 3 spec §2 inventory: pending_b2_blocks_ marked DELETED in §2.1 errata; the §5 forcing-decision propagation validation is now deferred to Batch 4 (block_map_, the next Class B candidate) with mandatory pre-Step-A writer-grep per spec §2.1 amendment. NO new bridges, NO new W45 fixtures (delete-of-dead-state per shepard 22:46:33Z + supervisor 23:36:13Z carve-out). NOT counted toward W45 §3.5 5-batch backstop per supervisor 23:49:22Z (current count holds at 4: python#6+python#7 fold-into-C + Phase 3 Batch 1+2). Numstat (vs HEAD 1343895): Python/jit/hir/builder.cpp +0 -6 (drain loop + clear) Python/jit/hir/builder.h +0 -8 (struct + vector field) Python/jit/hir/builder_state_c.h +4 -3 (Class B doc-list refresh + dead-state footnote) TOTAL: NET -13L pure deletion (forecast -15L; -2L variance). Pre-commit compile-check: testkeeper 23:52:59Z BUILD_EXIT=0, 3-test sanity green (partial_conversions + W22 + W44). W44 gate: PASS (2 markers, 0 production callers). Authorization: theologian 23:35:58Z + supervisor 23:36:13Z (A) DEAD-DELETE only (split from getSimpleExceptInfo per theologian different-shape-bisect-granularity reasoning).
diff --git a/Python/jit/hir/builder.cpp b/Python/jit/hir/builder.cpp
@@ -2601,12 +2601,6 @@ void HIRBuilder::translate(
         break;
       }
     }
-    // B2: drain pending blocks from emitInlineExceptionMatch.
-    for (auto& pb : pending_b2_blocks_) {
-      queue.emplace_back(pb.block, std::move(pb.frame));
-    }
-    pending_b2_blocks_.clear();
-
     JIT_DCHECK(
         tc.block->GetTerminator() != nullptr &&
             !tc.block->GetTerminator()->IsSnapshot(),
diff --git a/Python/jit/hir/builder.h b/Python/jit/hir/builder.h
@@ -626,14 +626,6 @@ class HIRBuilder {
   };
   std::vector<ExceptionTableEntry> exception_table_;
 
-  // B2: blocks that need to be added to the translation queue.
-  // emitInlineExceptionMatch populates this; translate() drains it.
-  struct PendingBlock {
-    BasicBlock* block;
-    FrameState frame;
-  };
-  std::vector<PendingBlock> pending_b2_blocks_;
-
   // Parse co_exceptiontable into exception_table_
   void parseExceptionTable();
 
diff --git a/Python/jit/hir/builder_state_c.h b/Python/jit/hir/builder_state_c.h
@@ -6,7 +6,8 @@
  * Class A members (5 immutable + nullable opaque pointers) extracted
  * from HIRBuilder. Class B members (block_map_, exception_table_, etc.)
  * remain C++-side and access via _cpp suffix bridges (push/clear/iterate)
- * until per-batch migration per spec §5 #1.
+ * until per-batch migration per spec §5 #1. (pending_b2_blocks_ was
+ * dead-state-deleted Phase 3 Batch 3 — zero writers post-W26 refactor.)
  *
  * Authorization: theologian 23:05:15Z + supervisor 23:02:34Z (Y) atomic.
  */
@@ -23,8 +24,8 @@ extern "C" {
 /* PhxHirBuilderState — opaque holder for HIRBuilder Class A state.
  * code + preloader are immutable post-ctor; current_func/func/kwnames
  * mutate during translate()/emit. Subsequent batches add Class B
- * opaque pointers (block_map, exception_table, pending_b2_blocks,
- * temps, static_method_stack). */
+ * opaque pointers (block_map, exception_table, temps,
+ * static_method_stack). */
 typedef struct PhxHirBuilderState {
     void *code;            /* PyCodeObject* (ctor, immutable) */
     const void *preloader; /* const Preloader& (ctor, immutable) */

Original file line number	Diff line number	Diff line change
`@@ -2601,12 +2601,6 @@ void HIRBuilder::translate(`
`2601`	`2601`	`break;`
`2602`	`2602`	`}`
`2603`	`2603`	`}`
`2604`		`- // B2: drain pending blocks from emitInlineExceptionMatch.`
`2605`		`- for (auto& pb : pending_b2_blocks_) {`
`2606`		`- queue.emplace_back(pb.block, std::move(pb.frame));`
`2607`		`- }`
`2608`		`- pending_b2_blocks_.clear();`
`2609`		`-`
`2610`	`2604`	`JIT_DCHECK(`
`2611`	`2605`	`tc.block->GetTerminator() != nullptr &&`
`2612`	`2606`	`!tc.block->GetTerminator()->IsSnapshot(),`