Skip to content

Commit ab07641

Browse files
SonicFieldSonicField
committed
W25 Step B-4: builder_emit_c.c lint-pattern extern cleanup (130 deleted)
Per W25 spec §3 Step B + supervisor [chat L2310] ACK on B-4 plan + theologian [chat L2306] cutoff (C1 count = 0 satisfies SINGLE-COMMIT bundle condition < 5). Largest §1b TU cleanup, completing W25 Step B. PER-EXTERN CLASSIFICATION (per spec §3 4-class taxonomy): Class A (in hir_c_api.h, deleted): 99 unique Class C2 BB (in hir_basic_block_c.h, deleted): 1 unique Class C2 IC (in hir_instr_c.h, deleted): 10 unique Class C1 (no header): 0 (2 grep false-positives were 'hir_c_api'/'hir_instr_c' header-name strings in comments) TOTAL: 112 unique functions across 130 file-scope extern lines (multi-line continuations + redeclarations account for 130 vs 112) CHANGES (+1/-153): Added #include "cinderx/Jit/hir/hir_c_api.h" (only hir_instr_c.h + hir_basic_block_c.h were included pre-B-4) Deleted 130 file-scope lint-pattern extern declarations + their multi-line continuations (153 lines total via Python multi-line-aware script; canonical decls now visible via #include hir_c_api.h) VERIFICATION: builder_emit_c.c now has 0 lint-pattern externs. Step C lint gate (when shipped) will pass for this TU. CUMULATIVE B-0..B-5+B-4: 7/7 §1b TUs + simplify_c.c + builder_emit_c.c = ALL §1b cleanup complete. 195 lint externs cleaned across 8 TUs (65 prior + 130 in B-4). §5.3 POST-STEP-B mutation re-run NOW READY per spec §5 acceptance. Expected outcome: BUILD_EXIT≠0 with errors at licm_c.c + pass_output_type_c.c hir_c_insert_before call sites (canonical 3-arg sig now visible via Step B includes, 2-arg callers fail to compile). testkeeper STRICT verify (CLAUDE.md ba00817 gate items 1-4 hardened) requested post-commit. Tree-clean discipline + verbatim trailer paste required. Per testkeeper [chat L2308] operational guidance: wait-for-clean-tree before scripts/build_phoenix.sh, abort+restart if commit lands during build. POSSIBLE FUNCTION-SCOPED EXTERN ISSUE PER B-5 PRECEDENT: Per B-5 lesson, function-scoped externs may also exist. My ^extern scan only catches file-scope. If post-include compile surfaces function-scoped extern conflicts (B-5 precedent: 2 cases caught by compile error), will fix with separate B-4-fix commit per CLAUDE.md no-amend. FULL-PASTE DISCIPLINE per supervisor [chat L2192]: testkeeper to paste verbatim build trailer + per-extern grep verification post-build per gate item (4) hardening. Authorization chain: - W25 spec §3: theologian L2017 - 4-class taxonomy: theologian L2189 - B-4 batching pre-analysis: theologian L2306 - Plan ACK: supervisor L2310
1 parent 2c289cd commit ab07641

1 file changed

Lines changed: 1 addition & 153 deletions

File tree

0 commit comments

Comments
 (0)