builder: 19 emit methods in C (13% of 144)

SonicField · SonicField · commit 7783df7182c5 · 2026-04-21T02:01:35.000-07:00
Port 3 more emit methods:
- emitStoreAttr (stack pop receiver+value, StoreAttr)
- emitLoadType (LoadField ob_type)
- emitCopyDictWithoutKeys (peek+replace stack top)

Also: emitIsOp, emitContainsOp, emitDeleteAttr, emitUnaryOp,
emitUnaryNot from prior uncommitted work.

19/144 builder.cpp emit methods now in C.
diff --git a/Python/jit/hir/builder.cpp b/Python/jit/hir/builder.cpp
@@ -3923,13 +3923,10 @@ void HIRBuilder::emitToBool(TranslationContext& tc) {
   phx_ptr_arr_push(&tc.frame.stack, coerced_result);
 }
 
+extern "C" void hir_builder_emit_copy_dict_without_keys_c(void *tc, void *func);
+
 void HIRBuilder::emitCopyDictWithoutKeys(TranslationContext& tc) {
-  PhxPtrArray& stack = tc.frame.stack;
-  Register* keys = static_cast<Register*>(stack.data[stack.count - 1]);
-  Register* subject = static_cast<Register*>(stack.data[stack.count - (1) - 1]);
-  Register* rest = temps_.AllocateStack();
-  tc.emitCopyDictWithoutKeys(rest, subject, keys, tc.frame);
-  stack.data[stack.count - (0) - 1] = rest;
+  hir_builder_emit_copy_dict_without_keys_c(static_cast<void*>(&tc), static_cast<void*>(current_func_));
 }
 
 extern "C" void hir_builder_emit_get_len_c(void *tc, void *func);
@@ -4578,14 +4575,12 @@ void HIRBuilder::emitStoreLocal(
   tc.emitAssign(dst, src);
 }
 
+extern "C" void hir_builder_emit_load_type_c(void *tc, void *func);
+
 void HIRBuilder::emitLoadType(
     TranslationContext& tc,
     const jit::BytecodeInstruction&) {
-  Register* instance = static_cast<Register*>(phx_ptr_arr_pop(&tc.frame.stack));
-  auto type = temps_.AllocateStack();
-  tc.emitLoadField(
-      type, instance, "ob_type", offsetof(PyObject, ob_type), TType);
-  phx_ptr_arr_push(&tc.frame.stack, type);
+  hir_builder_emit_load_type_c(static_cast<void*>(&tc), static_cast<void*>(current_func_));
 }
 
 void HIRBuilder::emitConvertPrimitive(
@@ -5337,13 +5332,12 @@ void HIRBuilder::emitPopJumpIfNone(
   tc.emitCondBranch(is_true, true_block, false_block);
 }
 
+extern "C" void hir_builder_emit_store_attr_c(void *tc, int oparg);
+
 void HIRBuilder::emitStoreAttr(
     TranslationContext& tc,
     const jit::BytecodeInstruction& bc_instr) {
-  Register* receiver = static_cast<Register*>(phx_ptr_arr_pop(&tc.frame.stack));
-  Register* value = static_cast<Register*>(phx_ptr_arr_pop(&tc.frame.stack));
-
-  tc.emitStoreAttr(receiver, value, bc_instr.oparg(), tc.frame);
+  hir_builder_emit_store_attr_c(static_cast<void*>(&tc), bc_instr.oparg());
 }
 
 void HIRBuilder::moveOverwrittenStackRegisters(
diff --git a/Python/jit/hir/builder_emit_c.c b/Python/jit/hir/builder_emit_c.c
@@ -274,3 +274,37 @@ void hir_builder_emit_contains_op_c(PhxTranslationContext *tc, void *func, int o
     phx_tc_emit(tc, hir_c_create_compare_reg(result, op, left, right, &tc->frame));
     phx_ptr_arr_push(&tc->frame.stack, result);
 }
+
+/* emitStoreAttr — pop receiver + value, emit StoreAttr */
+extern void *hir_c_create_store_attr_reg(void *recv, void *val, int name_idx, void *fs);
+
+void hir_builder_emit_store_attr_c(PhxTranslationContext *tc, int oparg) {
+    void *receiver = phx_ptr_arr_pop(&tc->frame.stack);
+    void *value = phx_ptr_arr_pop(&tc->frame.stack);
+    phx_tc_emit(tc, hir_c_create_store_attr_reg(receiver, value, oparg, &tc->frame));
+}
+
+/* emitLoadType — pop instance, LoadField ob_type, push */
+extern void *hir_c_create_load_field_reg(void *dst, void *recv, const char *name,
+                                          intptr_t offset, HirType type, int borrowed);
+
+void hir_builder_emit_load_type_c(PhxTranslationContext *tc, void *func) {
+    void *instance = phx_ptr_arr_pop(&tc->frame.stack);
+    void *type_reg = hir_func_alloc_register(func);
+    HirType t_type = HIR_TYPE_TYPE;
+    phx_tc_emit(tc, hir_c_create_load_field_reg(type_reg, instance, "ob_type",
+        offsetof(PyObject, ob_type), t_type, 0));
+    phx_ptr_arr_push(&tc->frame.stack, type_reg);
+}
+
+/* emitCopyDictWithoutKeys — peek keys+subject, emit, replace top */
+extern void *hir_c_create_copy_dict_without_keys_reg(void *dst, void *subj, void *keys, void *fs);
+
+void hir_builder_emit_copy_dict_without_keys_c(PhxTranslationContext *tc, void *func) {
+    PhxPtrArray *stack = &tc->frame.stack;
+    void *keys = stack->data[stack->count - 1];
+    void *subject = stack->data[stack->count - 2];
+    void *rest = hir_func_alloc_register(func);
+    phx_tc_emit(tc, hir_c_create_copy_dict_without_keys_reg(rest, subject, keys, &tc->frame));
+    stack->data[stack->count - 1] = rest;
+}
