Skip to content

Commit 149b7e2

Browse files
committed
docs: REABSORB-WHEN comment on hir_builder_emit_awaited_call_tail_c
Per pythia python#78 python#2 [chat L1986] orphan-bridge risk + supervisor [chat L1990] authorization (option b) + theologian [chat L1991] volunteer + landing. Adds a 5-line comment block above the bridge function that names the PartialConversion artifact origin + the trigger condition for reabsorbing the bridge into a full emitAnyCall C body. Comment text: PARTIAL CONVERSION ARTIFACT — emitAnyCall await-tail extracted while emitAnyCall opcode-switch + 3 INVOKE_* sub-methods (emitInvokeFunction, emitInvokeNative, emitInvokeMethod) remain C++. REABSORB WHEN: Tier 6 INVOKE_* family fully converts to C; then emitAnyCall fully converts and this bridge can inline back into the full C body. Addresses pythia python#78 python#2 'orphan-bridge if Tier 6 INVOKE_* defers' concern by anchoring the reabsorb-trigger in source (not just chat history), ensuring future readers can locate the architectural decision context without scrollback. Authorship: theologian (volunteered + drafted); generalist (committed per role boundary — theologian = design/advisory, generalist = commits). Authorization chain: - pythia python#78 python#2 surfaced bridge orphan-risk: chat L1986 - supervisor authorized option (b) source-comment: chat L1990 - theologian volunteered + drafted comment: chat L1991, L1995
1 parent 6786689 commit 149b7e2

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

Python/jit/hir/builder_emit_c.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3364,6 +3364,11 @@ extern void hir_builder_emit_get_awaitable_c(
33643364
extern void hir_builder_emit_yield_from_method_c(
33653365
PhxTranslationContext *tc, void *out, int code_flags);
33663366

3367+
/* PARTIAL CONVERSION ARTIFACT — emitAnyCall await-tail extracted while
3368+
* emitAnyCall opcode-switch + 3 INVOKE_* sub-methods (emitInvokeFunction,
3369+
* emitInvokeNative, emitInvokeMethod) remain C++. REABSORB WHEN: Tier 6
3370+
* INVOKE_* family fully converts to C; then emitAnyCall fully converts and
3371+
* this bridge can inline back into the full C body. */
33673372
void hir_builder_emit_awaited_call_tail_c(
33683373
PhxTranslationContext *tc,
33693374
void *func,

0 commit comments

Comments
 (0)