Add support for Java analysis #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2020
henryju
force-pushed
the
feature/java_support
branch
from
0030b69 to
d438041
Compare
henryju
changed the title
henryju
force-pushed
the
feature/java_support
branch
from
7194900 to
454d1ad
Compare
jblievremont
approved these changes
Feb 25, 2020
Contributor
jblievremont
left a comment
jblievremont
left a comment
There was a problem hiding this comment.
LGTM, with a few comments 😄
|
|
||
| Optional<ProjectBindingWrapper> binding = bindingManager.getBinding(fileUri); | ||
| AnalysisResultsWrapper analysisResults; | ||
| final Optional<GetJavaConfigResponse> javaConfigOptFinal = javaConfigOpt; |
Contributor
There was a problem hiding this comment.
Why not make it final from the beginning?
Member
Author
There was a problem hiding this comment.
Good catch, that's a pre-refactoring remain
| } | ||
| } | ||
|
|
||
| private void analyzeAllOpenJavaFiles() { |
Contributor
There was a problem hiding this comment.
I'm wondering whether it would make sense to refactor these analyzeAllXxx methods, e.g with a method named analyzeFiles(Predicate<URI>).
Member
Author
There was a problem hiding this comment.
I think using predicates will make it harder to understand what this is doing. Just to save the loop, I don't think it worth factorizing. WDYT?
| analyzeAllOpenJavaFiles(); | ||
| } | ||
|
|
||
| private boolean isTest(WorkspaceFolderSettings settings, URI fileUri, Optional<GetJavaConfigResponse> javaConfig) { |
| @JsonRequest("sonarlint/getJavaConfig") | ||
| CompletableFuture<GetJavaConfigResponse> getJavaConfig(String fileUri); | ||
|
|
||
| public static class GetJavaConfigResponse { |
Contributor
There was a problem hiding this comment.
Nitpick: might be worth a Javadoc link to the reference
henryju
force-pushed
the
feature/java_support
branch
from
2e6774a to
67e55c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.