Expire crash #431
Merged
Expire crash #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timization getting the expire map out of sync with the val
Collaborator
Author
|
This PR also contains a change to cause this scenario to reproduce with tests where previously it was not hit. |
This was referenced May 20, 2022
Closed
msotheeswaran-sc
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepOverwriteForSnapshot is a performance optimization designed to eliminate an unnecessary copy when we are about to overwrite the value anyways. Unfortunately this didn't correctly synchronize the expire map leading to an assertion failure and crash. The fix disables this optimization when an expire is present - we can reenable it in the future when we're not blocking a release.