6.3.0 Omnibus Fixes #426
Merged
6.3.0 Omnibus Fixes #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap also swapping refcounts
…. This can cause severe issues for snapshots
…her weak memory models)
…mic on aligned ints, but correctness matters
msotheeswaran-sc
approved these changes
May 17, 2022
This was referenced May 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a1ae21d - Fixes a use after free issue due to reference count corruption on the dict. std::swap was moving the reference counts, but ref counts must stay with the allocated object.
b9575a6 - An intermittent assert hit during async rehash
34b4dc0 - Improve shutdown hygene by avoiding destructors on exit. This prevents a crash on exit.
b775ec7 - Fix uninitialized variable on dictionary creation which could cause us to consume excessive memory.
8f925f4 - Prevent accidental rehash initiation when an async rehash is aborted. This can cause corruption and data loss when a snapshot is in flight
dfe092f - Respond to cancelled rehashes earlier to avoid wasted CPU
0b0a2fa - Use correct memory model for reference counting on the dict. This has no effect on X86
25119b1 - Add memory fence barriers to the replication backlog. This is important on weak memory model CPUs
a094b4a - Reduce TSAN warnings due to background time updates (this should have no production effect but reduces TSAN noise)
875b6a7 - Make async commands "opt-in" as it can change the percieved ordering across clients
455c5a8 - Resolve incorrect locking during repl backlog resize. This can cause corruption during replication. Potential cause of #423