Closed
Conversation
This allows setting a pre-compiled keymap while ensuring the keymap was created under the same keyboard handle, and more importantly, the same xkbcommon context within the same thread.
Contributor
|
I believe this will help on #1903 |
Author
|
Superseded by #1903 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows setting a pre-compiled keymap while ensuring the keymap was created under the same keyboard handle, and more importantly, the same xkbcommon context within the same thread.
This is related to stefanboca/niri#1 which adds per-device keyboard layout. To support this, if the keymap of a keyboard is different from that of the last used one, then we need to set the new keymap. Currently, the only methods to achieve this are
set_keymap_from_stringandset_xkb_config, which both require compiling the keymap every time on switching. The newget_keymapandset_keymapmethods thus allow caching the compiled keymaps, likely in a HashMap, to prevent redundant keymap compilations.