use set_keymap and get_keymap to proper handle keymap by Bot-wxt1221 · Pull Request #1903 · Smithay/smithay

Bot-wxt1221 · 2026-01-11T10:16:23Z

~~WM need keymap to process input. So change_keymap is neccessary.~~

Follow by #1803.

Fix #1926

Applied #1907 (I changed it a little bit as I was overflowded by the complie error. I wonder if it's the best practice.)

Problem mainly on niri-wm/niri#2314

~~Current impl is stupid. The correct way should be simulate a virtual keyboard handler like libinput backend.~~

~~But I have no interest in it. So let's just make it possible to solve all issue.~~

I believe it will solve all the problem.

By the way, I'm not familiar with rust so maybe a rust expert should review my code.

UPD: modifiers is much more natural and effective in my opinion.

Bot-wxt1221 · 2026-01-11T10:29:59Z

@PolyMeilex

Bot-wxt1221 · 2026-01-17T16:01:01Z

@PolyMeilex

YaLTeR · 2026-01-18T05:55:49Z

Seems this PR is necessary to unbreak wtype that broke after the last virtual keyboard PR.

@Bot-wxt1221 with this PR, wtype works for clients, but for compositor binds it still uses the wrong keymap. I'm actually not sure what's happening. In winit backend, wtype -M alt -k p -m alt results in

2026-01-18T05:53:17.396689Z DEBUG niri::input: on_keyboard modified=XK_Escape pressed=true
2026-01-18T05:53:17.400344Z DEBUG niri::input: on_keyboard modified=XK_Escape pressed=false

inside the self.niri.seat.get_keyboard().unwrap().input(... closure (and no r somehow?) and ^[r produced in the terminal.

If I do wtype -M alt then something really weird happens where niri still sees all the keys as normal, and compositor binds work, but keys stop doing input to any client.

src/wayland/virtual_keyboard/virtual_keyboard_handle.rs

Bot-wxt1221 · 2026-02-02T02:51:23Z

@YaLTeR Fixed.

YaLTeR

wvkbd no longer gets key stuck
but wtype is now unable to invoke compositor actions with modifiers. Here's WAYLAND_DEBUG for wtype -M alt -k r -m alt:

[1616354.165] {Default Queue}  -> zwp_virtual_keyboard_manager_v1#3.create_virtual_keyboard(wl_seat#4, new id zwp_virtual_keyboard_v1#5)
[1616354.231] {Default Queue}  -> zwp_virtual_keyboard_v1#5.keymap(1, fd 5, 229)
[1616354.238] {Default Queue}  -> wl_display#1.sync(new id wl_callback#6)
[1616359.209] {Display Queue} wl_display#1.delete_id(6)
[1616359.219] {Default Queue} wl_callback#6.done(0)
[1616359.242] {Default Queue}  -> zwp_virtual_keyboard_v1#5.modifiers(8, 0, 0, 0)
[1616359.252] {Default Queue}  -> wl_display#1.sync(new id wl_callback#6)
[1616365.517] {Display Queue} wl_display#1.delete_id(6)
[1616365.527] {Default Queue} wl_callback#6.done(0)
[1616365.533] {Default Queue}  -> zwp_virtual_keyboard_v1#5.key(0, 1, 1)
[1616365.538] {Default Queue}  -> wl_display#1.sync(new id wl_callback#6)
[1616369.365] {Display Queue} wl_display#1.delete_id(6)
[1616369.375] {Default Queue} wl_callback#6.done(0)
[1616371.443] {Default Queue}  -> zwp_virtual_keyboard_v1#5.key(0, 1, 0)
[1616371.453] {Default Queue}  -> wl_display#1.sync(new id wl_callback#6)
[1616375.324] {Display Queue} wl_display#1.delete_id(6)
[1616375.335] {Default Queue} wl_callback#6.done(0)
[1616377.618] {Default Queue}  -> zwp_virtual_keyboard_v1#5.modifiers(0, 0, 0, 0)
[1616377.633] {Default Queue}  -> wl_display#1.sync(new id wl_callback#6)
[1616381.680] {Display Queue} wl_display#1.delete_id(6)
[1616381.701] {Default Queue} wl_callback#6.done(0)
[1616381.709] {Default Queue}  -> zwp_virtual_keyboard_v1#5.destroy()

This just types "r" instead of resizing the window with Alt-r

src/wayland/virtual_keyboard/virtual_keyboard_handle.rs

Bot-wxt1221 · 2026-02-02T13:34:59Z

@YaLTeR Fixed again.

YaLTeR · 2026-02-02T14:40:22Z

On the latest push, I checked wtype and wvkbd and I couldn't break it.

Bot-wxt1221 · 2026-02-03T11:06:13Z

@PolyMeilex could you review this?

Bot-wxt1221 · 2026-02-13T12:31:51Z

Are there any work to do?

src/wayland/virtual_keyboard/virtual_keyboard_handle.rs

src/input/keyboard/mod.rs

Bot-wxt1221 · 2026-02-17T15:14:22Z

So 2 solutions here. 1. Revert previous one(It is just ok) and focus on rewriting(I would help with dorotac) 2. Finding a balance to fix most of problems.

This allows setting a pre-compiled keymap while ensuring the keymap was created under the same keyboard handle, and more importantly, the same xkbcommon context within the same thread.

PolyMeilex · 2026-02-17T23:06:55Z

I'll be totally honest, I have no idea what's going on in this code. It was foolish of me to assume that I do, during #1803 review 😄

It all seems to be disproportionately complex for what it does, which might suggest a deeper design flaw unrelated to the bug at hand.

So I would be leaning towards just reverting the first PR (catacomb compositor already reverts it). Not because I don't trust your judgment, but because I don't trust mine, and I would rather not dig us into a deeper hole 😄

Sorry that I don't have time currently to properly research this stuff.

Bot-wxt1221 · 2026-02-18T12:44:36Z

@PolyMeilex But I have to say that no compositer impl this properly. And you can verify it solve all exist problem. Yet we're in a big hole, but at least It seems that we can stop at here.

Bot-wxt1221 force-pushed the virtual_keyboard branch 2 times, most recently from 3d6c503 to a9a6e0a Compare January 11, 2026 10:22

Bot-wxt1221 force-pushed the virtual_keyboard branch from a9a6e0a to a659a34 Compare January 12, 2026 15:36

Bot-wxt1221 changed the title ~~fix: use change_keymap to allow WM handle keycode with the correct keymap~~ fix: allow ignore keymap reset to fix virtual_keyboard Jan 12, 2026

Bot-wxt1221 force-pushed the virtual_keyboard branch 5 times, most recently from 67f4c7e to b114ff2 Compare January 12, 2026 15:45

Bot-wxt1221 marked this pull request as draft January 12, 2026 15:47

Bot-wxt1221 force-pushed the virtual_keyboard branch from b114ff2 to 3bd3c18 Compare January 17, 2026 15:58

Bot-wxt1221 changed the title ~~fix: allow ignore keymap reset to fix virtual_keyboard~~ fix: use change_keymap to edit virtual_keyboard's keymap Jan 17, 2026

Bot-wxt1221 marked this pull request as ready for review January 17, 2026 16:00

Bot-wxt1221 mentioned this pull request Jan 18, 2026

wtype makes input unusable niri-wm/niri#2314

Open

Bot-wxt1221 force-pushed the virtual_keyboard branch from 05bd7d2 to fd505bc Compare January 18, 2026 04:37

chenkeao mentioned this pull request Jan 22, 2026

Clipboard Auto paste breaks KeyboardLayout widget noctalia-dev/noctalia-shell#1390

Closed

Bot-wxt1221 mentioned this pull request Jan 24, 2026

feat(input): add pre-compiled keymap #1907

Closed

Bot-wxt1221 force-pushed the virtual_keyboard branch 2 times, most recently from 721e9ca to 13e102c Compare January 24, 2026 16:22

Bot-wxt1221 changed the title ~~fix: use change_keymap to edit virtual_keyboard's keymap~~ use set_keymap and get_keymap to proper handle keymap Jan 24, 2026

Bot-wxt1221 force-pushed the virtual_keyboard branch 4 times, most recently from 43ef44c to e18b18b Compare January 25, 2026 02:38

Bot-wxt1221 mentioned this pull request Jan 25, 2026

fix: adapt to newer virtual_keyboard niri-wm/niri#3309

Draft

YaLTeR reviewed Jan 25, 2026

View reviewed changes

src/wayland/virtual_keyboard/virtual_keyboard_handle.rs Outdated Show resolved Hide resolved

YaLTeR reviewed Jan 25, 2026

View reviewed changes

src/wayland/virtual_keyboard/virtual_keyboard_handle.rs Show resolved Hide resolved

Bot-wxt1221 force-pushed the virtual_keyboard branch from 6cb3229 to f785d4d Compare February 2, 2026 02:50

Bot-wxt1221 force-pushed the virtual_keyboard branch from f785d4d to f4847ab Compare February 2, 2026 03:01

YaLTeR reviewed Feb 2, 2026

View reviewed changes

src/wayland/virtual_keyboard/virtual_keyboard_handle.rs Outdated Show resolved Hide resolved

src/wayland/virtual_keyboard/virtual_keyboard_handle.rs Outdated Show resolved Hide resolved

Bot-wxt1221 force-pushed the virtual_keyboard branch from 1c40760 to 0cd467a Compare February 2, 2026 13:34

Bot-wxt1221 requested a review from YaLTeR February 2, 2026 13:46

Bot-wxt1221 force-pushed the virtual_keyboard branch 2 times, most recently from f9db7f4 to c63b655 Compare February 2, 2026 14:35

Sempyos mentioned this pull request Feb 4, 2026

wtype sends wrong keycodes after 74d14be niri-wm/niri#3394

Closed

Bot-wxt1221 mentioned this pull request Feb 9, 2026

Modifiers broken for virtual keyboard protocol #1926

Closed

This was referenced Feb 10, 2026

[BUG] Virtual keyboard keymap regression breaks wtype after Smithay update (PR #2058) pop-os/cosmic-comp#2081

Closed

[BUG] Enigo-based paste methods (CtrlV, CtrlShiftV, ShiftInsert) cause TranscriptionManager stall on Linux Wayland cjpais/Handy#779

Closed

dcz-self reviewed Feb 16, 2026

View reviewed changes

src/wayland/virtual_keyboard/virtual_keyboard_handle.rs Show resolved Hide resolved

src/input/keyboard/mod.rs Show resolved Hide resolved

src/input/keyboard/mod.rs Outdated Show resolved Hide resolved

feat(input): add pre-compiled keymap

3bd4783

This allows setting a pre-compiled keymap while ensuring the keymap was created under the same keyboard handle, and more importantly, the same xkbcommon context within the same thread.

Bot-wxt1221 force-pushed the virtual_keyboard branch from c63b655 to cbc22d7 Compare February 17, 2026 16:27

feat: use set_keymap and get_keymap to proper handle keymap

f1e43ae

Bot-wxt1221 force-pushed the virtual_keyboard branch from cbc22d7 to f1e43ae Compare February 17, 2026 16:30

Bot-wxt1221 requested a review from dcz-self February 17, 2026 16:31

Bot-wxt1221 force-pushed the virtual_keyboard branch from f1e43ae to 6ed90bd Compare February 18, 2026 09:56

Bot-wxt1221 changed the title ~~use set_keymap and get_keymap to proper handle keymap~~ revert #1803 Feb 18, 2026

Bot-wxt1221 mentioned this pull request Feb 18, 2026

New keyboard impl #1937

Open

Bot-wxt1221 force-pushed the virtual_keyboard branch from 6ed90bd to f1e43ae Compare February 18, 2026 12:38

Bot-wxt1221 changed the title ~~revert #1803~~ use set_keymap and get_keymap to proper handle keymap Feb 18, 2026

Conversation

Bot-wxt1221 commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bot-wxt1221 commented Jan 11, 2026

Uh oh!

Bot-wxt1221 commented Jan 17, 2026

Uh oh!

YaLTeR commented Jan 18, 2026

Uh oh!

Uh oh!

Uh oh!

Bot-wxt1221 commented Feb 2, 2026

Uh oh!

YaLTeR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Bot-wxt1221 commented Feb 2, 2026

Uh oh!

YaLTeR commented Feb 2, 2026

Uh oh!

Bot-wxt1221 commented Feb 3, 2026

Uh oh!

Bot-wxt1221 commented Feb 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bot-wxt1221 commented Feb 17, 2026

Uh oh!

PolyMeilex commented Feb 17, 2026

Uh oh!

Bot-wxt1221 commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Bot-wxt1221 commented Jan 11, 2026 •

edited

Loading

Bot-wxt1221 commented Feb 18, 2026 •

edited

Loading