Conversation
…/SWC-registry into KadenZipfel-feature/gas-griefing
|
Shall we assign SWC id 126 to this one and finally close the gap? |
| transactions[transactionId].executed = true; | ||
| transactionId += 1; | ||
|
|
||
| Target target = new Target(); |
There was a problem hiding this comment.
why deploy a new target everytime?
There was a problem hiding this comment.
Good point. The problem that I'm looking at is, would I have to deploy the Target contract to the mainnet and reference the address to avoid compilation errors? Or is there some way I can circumvent the compilation error?
There was a problem hiding this comment.
oh, you can probably just delete that line, and do this:
function relay(Target target, bytes memory _data, uint _gasLimit) public {
maurelian
left a comment
maurelian
left a comment
There was a problem hiding this comment.
Actually... I have a doubt, but don't have time to look into it now.
Basically, I think the protection should be in Relayer, not Target.
| @@ -0,0 +1,19 @@ | |||
| # Title | |||
|
@kadenzipfel @maurelian can we get this PR merged? |
* Add details to requirement_simple bytecode locations * Tweak location info for SWC-128 * misformatted bytecode offsets * Update README.md Updating links and some minor textual changes. * Slightly more descriptive error * Print full error * Clarify scope (#220) * Kaden zipfel feature/gas griefing (#222) * Insufficient gas griefing * Add newlines * Fix improper newlines * Make changes to relayer contracts * Add CWE reference * Fix link * Rename to SWC-126 * No target redeploy * Fix compiler warnings * Update SWC definition [ci skip]
4 participants
CWE reference added.