Conversation
…on-container / scheme-container
Swagger redesign/update colors
…ult-margins-padding Reset default text margins, Add updated spacing to information-container, scheme-container
| } | ||
|
|
||
| a | ||
| div > a, a.info__extdocs.link |
There was a problem hiding this comment.
I think this might be a bit too ambiguous - maybe add the classname to be more specific:
div.opblock-tag > a
There was a problem hiding this comment.
there are multiple a tags under the div thats why its like that
There was a problem hiding this comment.
But you are styling all direct descendant a elements in all div elements...
Adding the div class .opblock-tag would be a bit more specific
src/style/_information.scss
Outdated
|
|
||
| .title | ||
| { | ||
| font-size: 36px; |
src/style/_layout.scss
Outdated
| { | ||
| font-size: 14px; | ||
| font-weight: bold; | ||
| display: flex; |
There was a problem hiding this comment.
Is this left over from my PR?
If so you should probable delete the flex props and re-add text-align: center
src/style/_models.scss
Outdated
|
|
||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; |
src/style/_models.scss
Outdated
| cursor: pointer; | ||
| transition: all .2s; | ||
|
|
||
| border-bottom: 1px solid rgba($section-models-border-color, .3); |
src/style/_variables.scss
Outdated
|
|
||
| $info-title-small-pre-font-color: $white !default; | ||
|
|
||
| $info-title-small-pre-font-size: 12px; |
src/style/_variables.scss
Outdated
| $opblock-tag-border-bottom-color: $bright-gray !default; | ||
| $opblock-tag-background-color-hover: $black !default; | ||
| $opblock-tag-h4-font-size: 2em; | ||
| $opblock-tag-small-font-size:1.4em; |
There was a problem hiding this comment.
pedantic, but make sure space after colon
|
Some tiny updates. Otherwise looks good |
src/style/main.scss
Outdated
| @@ -1,3 +1,8 @@ | |||
| html { | |||
| font-size: 62.5%; | |||
| } | |||
There was a problem hiding this comment.
Its part of support for EM for fonts which i started to bring in from Rodys branch
There was a problem hiding this comment.
needs to be in the .swagger-ui block - not in html
| @include text_headline(); | ||
| a.nostyle | ||
| { | ||
| @include text_title($size: $opblock-tag-h4-font-size); |
Rody-Kirwan
left a comment
Rody-Kirwan
left a comment
There was a problem hiding this comment.
Just a couple of small comments.
The main one is to move the font-size: 62.5% to the .swagger-ui class
| font-weight: 600; | ||
|
|
||
| color: $color; | ||
| font-family: $code-default-font-family; |
There was a problem hiding this comment.
should be 4 space indentation.
I think you may need to change your settings in vscode
Removing these changes
avoids injection of absolute paths into production stylesheets former output: `url(/Users/kyle/Code/ui/dist/fonts/roboto-light-webfont.woff2)` new output: `url(./fonts/roboto-light-webfont.woff2)`
makes our new `font-display: swap` play nicer; generally better for end users under poor network conditions
4 participants
This is for review only and should NOT be merged to facelift-demo