Add AudioFlac Variant to Support FLAC Uploads#65
Merged
Sleitnick merged 1 commit intoSleitnick:mainfrom Jan 13, 2025
Merged
Conversation
Owner
|
Thanks! Have you tested this out and confirmed it works? Asking because the docs for the Asset API do not include .flac files as supported. The actual upload prompt on the website does show it though. |
Contributor
Author
|
@Sleitnick Yes, but I tested using asphalt, and saw the asset get generated with everything being successful. |
Contributor
Author
|
@Sleitnick Here is my asphalt MR: |
Sleitnick
approved these changes
Jan 13, 2025
Contributor
|
I noticed that they started supporting more formats for manual upload but didn't document them as supported on the Open Cloud APIs. Strange. @Zidiam Have you tried to play back this audio in a game? |
Contributor
Author
|
@jackTabsCode Ya attached is a screenshot of .flac and .wav audio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
AudioFlacvariant to theAssetTypeenum, enabling.flacuploads through the Roblox Open Cloud. The changes include:AudioFlacvariant toAssetType..flactoaudio/flacincontent_type.asset_typeandtry_from_extensionto treat.flacas audio.This allows
rbxcloudto recognize FLAC files and forward them to Roblox’s asset creation APIs without throwing an “unknown extension” error.