feat: added logging#94
Merged
SlavaVedernikov merged 8 commits intoSlavaVedernikov:masterfrom Aug 14, 2024
Merged
Conversation
added 5 commits
August 12, 2024 16:48
Added serilog Added logging output option Added logging level option Added logging option binder Replaced console write line to logger Added logger configuration to cli commands SlavaVedernikov#21
Added command line builder Added logging middleware
Added validation error Updated strategies to use validation error Log validation errors
SlavaVedernikov
requested changes
Aug 14, 2024
| var siteContentSubDirectoriesOption = SiteContentSubDirectoriesOption.Get(); | ||
| var siteNoSitemapSubDirectoriesOption = SiteNoSitemapSubDirectoriesOption.Get(); | ||
|
|
||
| var loggingLevelOption = LoggingLevelOptions.Get(); |
Owner
There was a problem hiding this comment.
I think this can be removed now.
| Progress = new Progress<int>(i => | ||
| { | ||
| Console.WriteLine($"Processed {i} out of {ItemsCount} items"); | ||
| Log.Debug("Processed {ItemNumber} of {ItemsCount} items", i, ItemsCount); |
Owner
There was a problem hiding this comment.
Change this to Information
| else | ||
| { | ||
| Console.WriteLine($"Resolving wildcard Structures for '{item}'."); | ||
| Log.Debug("Resolving wildcard Structures for {Structure}", item); |
Owner
There was a problem hiding this comment.
Change to
Log.Information("Resolving wildcard Structures for {Path}", item);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added serilog
Added logging output option
Added logging level option
Added logging option binder
Replaced console write line to logger
Added logger configuration to cli commands
#21