The current TraderX CSV sample is rebuilding Json files in the execute-aac-strategy.bat (by default) but is rendering off of Yaml files in the draw-diagrams.bat script. This is working because draw-diagrams.bat is using outdated Yaml files for diagram generation.
When rebuilding newly genearted Json/Yaml data files and using those for diagram generation, an error is being encountered when trying to build diagrams for the TraderX Sample. Error appears to be related to an additional Flow node being created for Business Processes Json/Yaml files.
Steps to reproduce:
- Change the aac-type to Yaml in the TraderX execute-aac-strategy.bat
e.g. Line 3: `if not defined aac-type set "aac-type=Yaml"
- From
.\Samples\TraderX\CSV directory execute .\execute-aac-strategy.bat
- Review ExecuteTrades.yaml *see below
- From
.\Samples\TraderX\CSV directory execute .\draw-diagrams.bat
May be related to the IsConditional change?
Log output shown below:
Drawing Diagrams...
[17:24:48 ERR] File ..\Samples\TraderX\CSV\Architecture\Yaml\BusinessProcesses\ExecuteTrades.yaml has error at path TraderXExample.BusinessProcesses.ExecuteTrades.Activities[0].Flow: Property 'Flow' has not been defined and the schema does not allow additional properties.
ExecuteTrades.yaml:
TraderXExample:
BusinessProcesses:
EzecuteTrades:
Label: Execute Trades
Activities:
- Label: Create Trade Request
Actor: TraderXExample.Actors.Trader
Flow:
Flows:
- Type: Use
Expression: TraderXExample.SoftwareSystems.TraderX.Containers.WebClient.Interfaces.CreateTrade
IsConditional: false
IsConditional: false
- Label: Process Trade Request
Actor: TraderXExample.Actors.ExternalProcess
Flow:
Flows:
- Type: Use
Expression: TraderXExample.SoftwareSystems.TraderX.Containers.TradeProcessor.Interfaces.Start
IsConditional: false
IsConditional: false
- Label: Refresh Web Client
Actor: TraderXExample.Actors.ExternalProcess
Flow:
Flows:
- Type: Use
Expression: TraderXExample.SoftwareSystems.TraderX.Containers.WebGUI.Interfaces.Start
IsConditional: false
IsConditional: false
- Label: Cancel Trade
Actor: TraderXExample.Actors.Trader
Flow:
Flows:
- Type: Use
Expression: TraderXExample.SoftwareSystems.TraderX.Containers.WebClient.Interfaces.CancelTrade
IsConditional: false
IsConditional: false
The current TraderX CSV sample is rebuilding Json files in the
execute-aac-strategy.bat(by default) but is rendering off of Yaml files in thedraw-diagrams.batscript. This is working becausedraw-diagrams.batis using outdated Yaml files for diagram generation.When rebuilding newly genearted Json/Yaml data files and using those for diagram generation, an error is being encountered when trying to build diagrams for the TraderX Sample. Error appears to be related to an additional
Flownode being created for Business Processes Json/Yaml files.Steps to reproduce:
e.g. Line 3: `if not defined aac-type set "aac-type=Yaml"
.\Samples\TraderX\CSVdirectory execute.\execute-aac-strategy.bat.\Samples\TraderX\CSVdirectory execute.\draw-diagrams.batMay be related to the IsConditional change?
Log output shown below:
Drawing Diagrams...
[17:24:48 ERR] File ..\Samples\TraderX\CSV\Architecture\Yaml\BusinessProcesses\ExecuteTrades.yaml has error at path TraderXExample.BusinessProcesses.ExecuteTrades.Activities[0].Flow: Property 'Flow' has not been defined and the schema does not allow additional properties.
ExecuteTrades.yaml: