Material 3 redesign#960
Merged
ilyassesalama merged 48 commits intoSketchware-Pro:material-redesignfrom Sep 3, 2023
aikrq:material-redesign
Merged
Material 3 redesign#960ilyassesalama merged 48 commits intoSketchware-Pro:material-redesignfrom aikrq:material-redesign
ilyassesalama merged 48 commits intoSketchware-Pro:material-redesignfrom
aikrq:material-redesign
Conversation
Collaborator
aikrq
commented
Sep 3, 2023
aikrq
commented
These colors were generated by the site: https://m3.material.io/theme-builder
I was disappointed of using primary fixed colors hels
…ut/palette_widget
Also upgrade compileSdkVersion to 34
|
|
||
| android { | ||
| compileSdk 33 | ||
| compileSdkVersion 34 |
Collaborator
There was a problem hiding this comment.
compileSdkVersion is deprecated, why did you remove compileSdk?
| float var3 = Math.min((float) (var9 - var4 * 2) / (float) displayWidth, (float) (var8 - var5 * 2) / (float) displayHeight); | ||
| if (!isLandscapeMode) { | ||
| aa.setBackgroundResource(R.drawable.new_view_pane_background_port); | ||
| //aa.setBackgroundResource(R.drawable.new_view_pane_background_port); |
Collaborator
There was a problem hiding this comment.
Why did you remove layout editor's phone frame?
Collaborator
Author
There was a problem hiding this comment.
It was just for testing purposes.
Collaborator
|
Looks good to me, I'll fix the issues that I mentioned before, and a few others I found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.