Fix moreblock collection preview in list item#956
Merged
j-px merged 7 commits intoSketchware-Pro:mainfrom Sep 4, 2023
Merged
Conversation
Collaborator
elfilibusterismo
commented
Aug 29, 2023
elfilibusterismo
commented
j-px
requested changes
Aug 29, 2023
Contributor
j-px
left a comment
j-px
left a comment
There was a problem hiding this comment.
overall another nice contribution! there's just a few improvements needed.
app/src/main/java/mod/hey/studios/moreblock/importer/MoreblockImporterDialog.java
Show resolved
Hide resolved
app/src/main/res/layout/manage_collection_popup_import_more_block_list_item.xml
Outdated
Show resolved
Hide resolved
app/src/main/java/com/besome/sketch/editor/manage/ManageCollectionActivity.java
Show resolved
Hide resolved
elfilibusterismo
force-pushed
the
fix-moreblock-collection
branch
2 times, most recently
from
c09bf24 to
aed9a5b
Compare
Used a.a.a.Rs class instead of using 9 patch as background resource
This will make the block name not overlap the block area
elfilibusterismo
force-pushed
the
fix-moreblock-collection
branch
from
aed9a5b to
8c5df4c
Compare
Contributor
|
i forgot the review stuff before merging lol |
j-px
reviewed
Sep 4, 2023
Contributor
There was a problem hiding this comment.
im not really sure what benefits this brings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.