Skip to content

Fix and Feat Custom Variable#912

Merged
j-px merged 8 commits intoSketchware-Pro:mainfrom
elfilibusterismo:main
Sep 17, 2023
Merged

Fix and Feat Custom Variable#912
j-px merged 8 commits intoSketchware-Pro:mainfrom
elfilibusterismo:main

Conversation

@elfilibusterismo
Copy link
Collaborator

@elfilibusterismo elfilibusterismo commented Jul 14, 2023

No description provided.

@j-px
Copy link
Contributor

j-px commented Jul 14, 2023

why did you close the PR?? now the reviews are "gone"

@elfilibusterismo
Copy link
Collaborator Author

elfilibusterismo commented Jul 14, 2023

why did you close the PR?? now the reviews are "gone"

Sorry, I forgot.
If I'm not mistaken this is the exact review message

•an indent has 4 spaces
•after ifs, switches, etc. and before e.g. {s there should be a space
•and also very important: no stray lines before a class' fields (like in CustomVariableUtil.java) as well as before one's last }

@j-px
Copy link
Contributor

j-px commented Jul 14, 2023

no, I also meant these:
image

@elfilibusterismo
Copy link
Collaborator Author

elfilibusterismo commented Jul 14, 2023

no, I also meant these:
image

In validators class
You said, remove the redundant 'this' and make the pattern static final.

LogicClickListener.java
For validator of modifier and type you've notice the error message not having colon
and for local variable not needed, so i just directly used toAdd.toString().trim()

ExtraPaletteBlock.java
You and hasrat said about Custom List being already exists, so I removed it from Custom Variable.

@j-px
Copy link
Contributor

j-px commented Jul 14, 2023

nooo, I didn't ask you to list all and explain what you did, come on lol

@hasrat-ali
Copy link
Contributor

hasrat-ali commented Jul 14, 2023

Why haven't you removed the new custom variable (6) yet?

Why you even need that?

@elfilibusterismo
Copy link
Collaborator Author

elfilibusterismo commented Jul 14, 2023

Why haven't you removed the new custom variable (6) yet?

Why you even need that?

20230715_025426.png

j-px
j-px requested changes Jul 14, 2023
View reviewed changes
@j-px
Copy link
Contributor

j-px commented Jul 14, 2023

please don't open another PR again after you make adjustments

j-px
j-px requested changes Jul 16, 2023
View reviewed changes
@j-px j-px added improvement Enhances an existing feature or internal logic. fix This pull request contains a bugfix labels Jul 21, 2023
@elfilibusterismo
Copy link
Collaborator Author

elfilibusterismo commented Jul 22, 2023

Forgot to revert the format codes. Sorry

@elfilibusterismo elfilibusterismo requested a review from j-px July 23, 2023 02:21
j-px
j-px requested changes Jul 23, 2023
View reviewed changes
@j-px j-px mentioned this pull request Aug 10, 2023
Closed
@ilyassesalama ilyassesalama added the working on it This issue/pull request is being worked on in the meantime label Aug 11, 2023
@j-px j-px linked an issue Aug 19, 2023 that may be closed by this pull request
Custom Variable show errors #947
Closed
j-px added 4 commits September 10, 2023 19:52
@j-px
style: Reformat files touched by previous commits
0e59c76
@j-px
chore: Clean up Custom Variable validation mess
968a990 
This was unnecessarily complicated.
@j-px
feat: Treat Custom Variables with type wrapper class as Block-compati…
62ff077 
…ble too

Allows also using Custom Variables with type e.g. `Boolean` to be used like a Boolean Variable, not just `boolean`, `int`, etc.
@j-px
feat: Allow using Custom Variables with type short as Number Variables
23224ec
@j-px j-px merged commit 4a7f8e6 into Sketchware-Pro:main Sep 17, 2023
@j-px j-px removed the working on it This issue/pull request is being worked on in the meantime label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-px j-px j-px requested changes

@ilyassesalama ilyassesalama ilyassesalama left review comments

Assignees

No one assigned

Labels

fix This pull request contains a bugfix improvement Enhances an existing feature or internal logic.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom Variable show errors

4 participants

@elfilibusterismo @j-px @hasrat-ali @ilyassesalama