Add R8 code shrinker (Improved version of #720)#895
Merged
j-px merged 35 commits intoSketchware-Pro:mainfrom Jul 10, 2023
PranavPurwar:detached
Merged
Add R8 code shrinker (Improved version of #720)#895j-px merged 35 commits intoSketchware-Pro:mainfrom PranavPurwar:detached
j-px merged 35 commits intoSketchware-Pro:mainfrom
PranavPurwar:detached
Conversation
…de:DependencyResolver`
…library already exists, more verbose logging, auto enable downloaded dependencies, extract Handler out of lambda, make toasted messages less ambigious
…oncurrentModificationException` when you click `Start` twice
…Local library Downloader repositories
j-px
requested changes
Jul 7, 2023
Contributor
j-px
left a comment
There was a problem hiding this comment.
seems really improved though
app/src/main/java/mod/hey/studios/project/proguard/ManageProguardActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/mod/hey/studios/project/proguard/ProguardHandler.java
Outdated
Show resolved
Hide resolved
j-px
requested changes
Jul 8, 2023
app/src/main/java/mod/hey/studios/build/BuildSettingsDialog.java
Outdated
Show resolved
Hide resolved
app/src/minApi21/java/mod/hey/studios/build/BuildSettingsDialogBridge.java
Outdated
Show resolved
Hide resolved
app/src/minApi26/java/mod/hey/studios/build/BuildSettingsDialogBridge.java
Outdated
Show resolved
Hide resolved
j-px
requested changes
Jul 10, 2023
app/src/main/java/mod/hey/studios/project/proguard/ProguardHandler.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Merge now |
If it's in code, the g shouldn't be capitalized. If it's user-facing, it should.
Contributor
|
i somehow feel like you didn't even preview Code Shrinking Manager while editing its XML file |
Collaborator
Author
|
yooooooo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title is self explanatory.