upgrade library manager to download subdependencies too#894
Merged
j-px merged 17 commits intoSketchware-Pro:mainfrom Jun 25, 2023
PranavPurwar:swpro-deez-nutz
Merged
upgrade library manager to download subdependencies too#894j-px merged 17 commits intoSketchware-Pro:mainfrom PranavPurwar:swpro-deez-nutz
j-px merged 17 commits intoSketchware-Pro:mainfrom
PranavPurwar:swpro-deez-nutz
Conversation
…de:DependencyResolver`
j-px
reviewed
Jun 24, 2023
app/src/main/java/dev/aldi/sayuti/editor/manage/ManageLocalLibraryActivity.java
Outdated
Show resolved
Hide resolved
…library already exists, more verbose logging, auto enable downloaded dependencies, extract Handler out of lambda, make toasted messages less ambigious
Contributor
|
Looking good so far. Just one issue, the entire app crashes thanks to an uncaught FileNotFoundException when trying to download the artifact |
…oncurrentModificationException` when you click `Start` twice
Collaborator
Author
Fixed |
j-px
reviewed
Jun 25, 2023
…Local library Downloader repositories
Contributor
Record_2023-06-25-22-19-08.mp4Nice 👍👍👍 |
Contributor
|
Contributor
|
Ohh yeah, but still not downloading |
Collaborator
Author
Check the solutions provided in the stackoverflow post |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improves the performance and experience significantly