Include built-in libraries in exported projects' build.gradle#868
Merged
j-px merged 16 commits intoSketchware-Pro:mainfrom Jun 13, 2023
Merged
Include built-in libraries in exported projects' build.gradle#868j-px merged 16 commits intoSketchware-Pro:mainfrom
j-px merged 16 commits intoSketchware-Pro:mainfrom
Conversation
YoutubePlayer CodeView OTPView LottieAnimation OneSignal PatternLockView
YoutubePlayer CodeView OTPView LottieAnimation OneSignal PatternLockView
Contributor
Author
|
@HAKANKOKCU and me does not know which lib version is used in few libs so we leaved them empty. |
DevVigilante
changed the title
j-px
requested changes
May 10, 2023
Contributor
j-px
left a comment
j-px
left a comment
There was a problem hiding this comment.
maybe it would have been better if no separate class was created since the changes are trivial: just a few more if statements and nothing complicated. we've fixed stuff like that with e.g. commit 4a92e19.
anyway, sorry, but I don't think code like this should be merged. it was clearly not written using a proper IDE and the indentation is messed up.
DevVigilante
force-pushed
the
include_lib_in_gradle
branch
from
4c4b2ee to
9af0162
Compare
Should improve performance by a bit since every `ExcludeBuiltInLibrariesActivity#isExcludingEnabled` call causes I/O operations.
j-px
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I(@TechnicalStudioDeveloper) wrote logic of adding libs used in project and @HAKANKOKCU added lib list for logic.
Implementation code
CircleImageView =>
de.hdodenhof:circleimageview:3.1.0YoutubePlayer =>
com.pierfrancescosoffritti:androidyoutubeplayer:10.0.5CodeView =>
br.tiagohm:codeview:0.4.0LottieAnimation =>
com.airbnb:lottie:3.4.0OTPView =>
affan.ahmad:otp:0.1.0OneSignal =>
com.onesignal:OneSignal:3.14.0PatternLockView =>
com.andrognito:patternlockview:1.0.0