refactor: Refactored some classes name, method name, etc#815
Merged
j-px merged 20 commits intoSketchware-Pro:mainfrom May 11, 2023
Merged
refactor: Refactored some classes name, method name, etc#815j-px merged 20 commits intoSketchware-Pro:mainfrom
j-px merged 20 commits intoSketchware-Pro:mainfrom
Conversation
After refactoring Mx.java, it became necessary to update yq.java to reflect the changes.
Update yq.java
Collaborator
|
hey, are you sure everything works after that change? Because I think most of what depends on these classes a.a.a.* is still obfuscated, in binary format, so that might cause some issues |
Contributor
Author
|
Build was successful but still testing it (apk) |
Contributor
Author
|
I tested debug min api 26 apk on Android 10 it worked fine but still testing it |
Contributor
Author
|
I think it's fine. When I checked the "a.a.a-important" and "a.a.a-notimportant" jars, I found that they do not depend on any modified Java files within them. |
CyberXCoder-6649
changed the title
j-px
approved these changes
May 10, 2023
Contributor
j-px
left a comment
j-px
left a comment
There was a problem hiding this comment.
although such refactors are unusual imo, this lgtm!
i'll add minor fixes myself
app/src/minApi21/java/mod/hey/studios/compiler/kotlin/KotlinCompilerBridge.java
Outdated
Show resolved
Hide resolved
app/src/minApi26/java/mod/hey/studios/compiler/kotlin/KotlinCompilerBridge.java
Show resolved
Hide resolved
Contributor
|
feels like ChatGPT wrote the description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the a.a.a.* package and other packages that relied on it. The refactoring involved improving the code structure and method names to enhance code readability and maintainability.
The changes made to the a.a.a.* package affected several other packages that depended on it. Therefore, relevant files in those packages were also updated to ensure compatibility and functionality.
By making these changes, the codebase should be easier to understand and maintain. Additionally, the code is now more modular, making it easier to modify and extend.
Overall, this refactoring effort should lead to a more efficient development process and improved code quality.