Implement R8 shrinker#720
Implement R8 shrinker#720PranavPurwar wants to merge 11 commits intoSketchware-Pro:mainfrom PranavPurwar:main
Conversation
j-px
left a comment
There was a problem hiding this comment.
Looks all-in-all neat, but to me, having R8/ProGuard in Build Settings is a bad UI decision. I think it should be adjustable in ProGuard Manager instead.
app/src/minApi21/java/mod/hey/studios/build/BuildSettingsDialogBridge.java
Show resolved
Hide resolved
I did this in a hurry, didn't really think of that. |
|
bro sir what happened in the last commit |
To be honest, the whole build dialog is a bad UI decision. IMO, when the user clicks on "build settings" button, an activity should appear showing all possible toggles or modifications that can be made, and even shortcuts to take you to specific activities such as ProGuard settings. You may ask, why I have chosen an activity? It is because the current UI has become so crowded, and future features will not fit there well. So, it's better to take a step ahead to solve this issue permanently. |
in my opinion, "build settings" should stay the way it is offering unique and quick options to be adjusted, and not creating an activity full of options that already exist in their own sections,for advanced sections we have the drawer on the right, last position where you can add anything for advanced controls,without messing up the sketchware interface that everyone is used to. |
|
merge now |
This comment was marked as spam.
This comment was marked as spam.
@moderGamer yes, but its much more efficient and better |
This comment was marked as spam.
This comment was marked as spam.
@moderGamer its the upstream changes causing issue |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
@moderGamer did you enable proguard in settings? |
This comment was marked as spam.
This comment was marked as spam.
you need to enable that to start the shrinker |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
I didn't talk to you, bruh. |
|
@TheRemakerMan you downloaded the minApi21 variant, its only available on minApi26 variant due to NIO dependency of R8/D8 |
Oh, thanks. |
This comment was marked as spam.
This comment was marked as spam.
|
@moderGamer Enable proguard from the drawer and enable R8 from build settings dialog and build the project |
This comment was marked as spam.
This comment was marked as spam.
name db 'r8', 0xa settings dd 1 mov name, settings

No description provided.