Skip to content

Implement R8 shrinker#720

Closed
PranavPurwar wants to merge 11 commits intoSketchware-Pro:mainfrom
PranavPurwar:main
Closed

Implement R8 shrinker#720
PranavPurwar wants to merge 11 commits intoSketchware-Pro:mainfrom
PranavPurwar:main

Conversation

@PranavPurwar
Copy link
Collaborator

No description provided.

Copy link
Contributor

@j-px j-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all-in-all neat, but to me, having R8/ProGuard in Build Settings is a bad UI decision. I think it should be adjustable in ProGuard Manager instead.

@j-px j-px added the feature A new feature label Jan 29, 2023
@PranavPurwar
Copy link
Collaborator Author

Looks all-in-all neat, but to me, having R8/ProGuard in Build Settings is a bad UI decision. I think it should be adjustable in ProGuard Manager instead.

I did this in a hurry, didn't really think of that.

@j-px
Copy link
Contributor

j-px commented Jan 30, 2023

bro sir what happened in the last commit

@ilyassesalama
Copy link
Collaborator

Looks all-in-all neat, but to me, having R8/ProGuard in Build Settings is a bad UI decision. I think it should be adjustable in ProGuard Manager instead.

To be honest, the whole build dialog is a bad UI decision. IMO, when the user clicks on "build settings" button, an activity should appear showing all possible toggles or modifications that can be made, and even shortcuts to take you to specific activities such as ProGuard settings.

You may ask, why I have chosen an activity? It is because the current UI has become so crowded, and future features will not fit there well. So, it's better to take a step ahead to solve this issue permanently.
You may also ask, how would the activity look? In my opinion, I think it should look like AndroidManifest Manager screen.

@DereckySany
Copy link

Looks all-in-all neat, but to me, having R8/ProGuard in Build Settings is a bad UI decision. I think it should be adjustable in ProGuard Manager instead.

To be honest, the whole build dialog is a bad UI decision. IMO, when the user clicks on "build settings" button, an activity should appear showing all possible toggles or modifications that can be made, and even shortcuts to take you to specific activities such as ProGuard settings.

You may ask, why I have chosen an activity? It is because the current UI has become so crowded, and future features will not fit there well. So, it's better to take a step ahead to solve this issue permanently. You may also ask, how would the activity look? In my opinion, I think it should look like AndroidManifest Manager screen.

in my opinion, "build settings" should stay the way it is offering unique and quick options to be adjusted, and not creating an activity full of options that already exist in their own sections,for advanced sections we have the drawer on the right, last position where you can add anything for advanced controls,without messing up the sketchware interface that everyone is used to.

@PranavPurwar
Copy link
Collaborator Author

merge now

@moderGamer

This comment was marked as spam.

@PranavPurwar
Copy link
Collaborator Author

Hi, does this feature encrypt the project like ProGuard?

@moderGamer yes, but its much more efficient and better

@moderGamer

This comment was marked as spam.

@PranavPurwar
Copy link
Collaborator Author

Very good, so fix the error so that it is added to the new sketchware feature, thank you

@moderGamer its the upstream changes causing issue

@PranavPurwar PranavPurwar requested a review from j-px February 21, 2023 16:38
@moderGamer

This comment was marked as spam.

@moderGamer

This comment was marked as spam.

@PranavPurwar
Copy link
Collaborator Author

@moderGamer did you enable proguard in settings?

@moderGamer

This comment was marked as spam.

@aikrq
Copy link
Collaborator

aikrq commented Feb 22, 2023

Screenshot_20230222-112759.jpg

@PranavPurwar
Copy link
Collaborator Author

no bro

you need to enable that to start the shrinker

@PranavPurwar
Copy link
Collaborator Author

Screenshot_20230222-112759.jpg

Are you on less than API 26 device?

@moderGamer

This comment was marked as spam.

@aikrq
Copy link
Collaborator

aikrq commented Feb 22, 2023

Screenshot_20230222-112759.jpg

Are you on less than API 26 device?

No, I have a device with the 30 api version.

@moderGamer

This comment was marked as spam.

@aikrq
Copy link
Collaborator

aikrq commented Feb 22, 2023

my android version 11

@TheRemakerMan

I didn't talk to you, bruh.

@PranavPurwar
Copy link
Collaborator Author

@TheRemakerMan you downloaded the minApi21 variant, its only available on minApi26 variant due to NIO dependency of R8/D8

@aikrq
Copy link
Collaborator

aikrq commented Feb 22, 2023

@TheRemakerMan you downloaded the minApi21 variant, its only available on minApi26 variant due to NIO dependency of R8/D8

Oh, thanks.

@moderGamer

This comment was marked as spam.

@PranavPurwar
Copy link
Collaborator Author

@moderGamer Enable proguard from the drawer and enable R8 from build settings dialog and build the project

@moderGamer

This comment was marked as spam.

DereckySany added a commit to DereckySany/Sketchware-Pro-aapt1_aapt2_multilib that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants