refactor, fix and optimize about activites and fragments#1682
Conversation
yoann256
commented
Jun 21, 2025
yoann256
commented
- AboutActivity.java got some fixes and optimizations
- BetaChangesFragment.java and ChangeLogFragment.java got fixes and optimization
app/src/main/java/pro/sketchware/activities/about/AboutActivity.java
Outdated
Show resolved
Hide resolved
trindadedev13
added
improvement
hasrat-ali
force-pushed
the
refactor/about-activity-fragments
branch
2 times, most recently
from
ee8c624 to
1bab63d
Compare
Infinite scroll no longer calls loadCommitData() multiple times Pagination no longer overwrites data try-catch no longer outside network callback
hasrat-ali
force-pushed
the
refactor/about-activity-fragments
branch
from
1bab63d to
d555b41
Compare
|
After removing the useless changes, the changes that are left don't seem right to me. And I also found a bug, it is not showing the current version, it is just showing new update. But if you feel that we have made a mistake, please open a new pull request and explain the changes with full details. |
It's not his bug. The issue is simply because the commit hash doesn't exist in the main branch, which is why it appears that way Btw, I reviewed his changes, and I believe they're unnecessary anyway |
|
Oh, you reverted some of his changes. I just noticed that I think you should merge it, as his changes will prevent the app from crashing if GitHub API temporarily blocks the user's IP due to too many requests |
6 participants
