Skip to content

fix: crash if blocks.json is invalid json#1400

Merged
ilyassesalama merged 1 commit intoSketchware-Pro:mainfrom
delkotlin:ho
Nov 20, 2024
Merged

fix: crash if blocks.json is invalid json#1400
ilyassesalama merged 1 commit intoSketchware-Pro:mainfrom
delkotlin:ho

Conversation

@trindadedev13
Copy link
Collaborator

No description provided.

@ilyassesalama ilyassesalama added fix This pull request contains a bugfix merged This pull request was merged, it's only GitHub not showing it as merged. labels Nov 20, 2024
@ilyassesalama ilyassesalama merged commit bce788a into Sketchware-Pro:main Nov 20, 2024
@trindadedev13 trindadedev13 deleted the ho branch November 20, 2024 23:50
@PranavPurwar
Copy link
Collaborator

A toast or notification would be better to let the user know its broken

@trindadedev13
Copy link
Collaborator Author

A toast or notification would be better to let the user know its broken

if the user open or create a palette, the json of blocks.xml is saved with valid json, so I don't think it's necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix This pull request contains a bugfix merged This pull request was merged, it's only GitHub not showing it as merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants