Fix: Library download Problem and unziping#1364
Merged
hasrat-ali merged 6 commits intoSketchware-Pro:mainfrom Nov 19, 2024
rajendrakrdangi:main
Merged
Fix: Library download Problem and unziping#1364hasrat-ali merged 6 commits intoSketchware-Pro:mainfrom rajendrakrdangi:main
hasrat-ali merged 6 commits intoSketchware-Pro:mainfrom
rajendrakrdangi:main
Conversation
This comment was marked as spam.
This comment was marked as spam.
… to 16 - Replaced usage of the toList() method (introduced in Java 16) with collect(Collectors.toList()) to ensure compatibility with older Java versions.
sketchide
approved these changes
Nov 14, 2024
|
why this pr not accepted? |
Contributor
Author
i don't know maybe the maintainer has busy in other work |
Collaborator
|
I'll review it as soon as I can, but a review from @PranavPurwar or @khaled-0 would be appreciated. I can't recall who made this feature before. |
Contributor
Author
as your wish my dear friend |
khaled-0
reviewed
Nov 19, 2024
app/src/main/java/dev/aldi/sayuti/editor/manage/LibraryDownloaderDialogFragment.java
Outdated
Show resolved
Hide resolved
khaled-0
reviewed
Nov 19, 2024
khaled-0
approved these changes
Nov 19, 2024
app/src/main/java/mod/pranav/dependency/resolver/DependencyResolver.kt
Outdated
Show resolved
Hide resolved
added Comment :// this is pretty much the same as `Artifact.downloadArtifact()`, but with some modifications for checks and callbacks
Updated comment and removed extra spaces
This was referenced Nov 19, 2024
ilyassesalama
added
fix
Collaborator
|
It seems the issue is still there. Someone reported the same issue today using latest nightly build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Crashing during downloading library