DependencyResolver: Update version and fix d8 invocation (rfc)#1162
Merged
ilyassesalama merged 4 commits intomainfrom Jun 30, 2024
Merged
DependencyResolver: Update version and fix d8 invocation (rfc)#1162ilyassesalama merged 4 commits intomainfrom
ilyassesalama merged 4 commits intomainfrom
Conversation
This is a partial copy of commit 4d1e52a.
(cherry picked from commit 8e8970a)
…endencyResolver Somehow, them as classpath files makes d8 create strange class references like `Landroid/app/Application$ActivityLifecycleCallbacks$-CC` in dex files. According to [1], android.jar should be passed as library input, so apply that here too. [1]: https://r8.googlesource.com/r8/
|
Great job! |
Contributor
Author
|
If you don't have anything useful to contribute, please don't comment. |
ilyassesalama
added
fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subset of #1141 with the unrelated dependency version bumps removed. It also fixes compiling downloaded Local libraries, which together with the sped up dependency resolver allowed me to create a project that uses
com.google.android.material:material:1.12.0successfully.Comments, anyone?
Fixes #1139.